Bug 44555

Summary: Garbled glyphs in Firefox 9 [SNA]
Product: xorg Reporter: Clemens Eisserer <linuxhippy>
Component: Driver/intelAssignee: Chris Wilson <chris>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium    
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
screenshot none

Description Clemens Eisserer 2012-01-07 05:28:57 UTC
Created attachment 55264 [details]
screenshot

Since updating intel to trunk again recently, I see corrupted glyphs in firefox from time to time which I haven't seen during my earlier SNA testing.
Screenshot is attached.


intel i945GM
linux 3.1.6
Xorg 1.11.3-1
pixman 0.24
SNA compiled from 2.17.0-338-ge2ad0f6
Comment 1 Chris Wilson 2012-01-07 10:15:43 UTC
I think this is

commit 292aebfcdc042b08d3a5a21f839e6aec1175359e
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Sat Jan 7 18:09:47 2012 +0000

    sna: Prevent reuse of scanlines after the buffer is destroyed
    
    Once the buffer is destroyed, it may be reallocated with a new pitch. We
    could track handle and pitch, but it is easier to simply restart the
    blit after the buffer is freed.
    
    References: https://bugs.freedesktop.org/show_bug.cgi?id=44277
    References: https://bugs.freedesktop.org/show_bug.cgi?id=44555
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Can you retest with master?
Comment 2 Clemens Eisserer 2012-01-07 10:41:21 UTC
fixed, thanks
Comment 3 Chris Wilson 2012-01-07 10:45:55 UTC
* sigh.

Can you check that you tested with c05e90aa9, as the patch I originally pushed missed a couple of chunks and effectively completely disabled the XY_SETUP_BLT reuse.
Comment 4 Clemens Eisserer 2012-01-07 11:24:14 UTC
Strange, I did a fresh clone and it works as expected - but the driver still reports:

[ 30281.119] (II) intel(0): SNA compiled from 2.17.0-341-gc05e90a

... although the latest commit is clearly labeled as: c05e90aa9
Comment 5 Chris Wilson 2012-01-07 13:53:39 UTC
I have no idea why git describe puts that 'g' before the commit id, there is probably a rational explanation that I simply don't understand.

Thanks for confirming that restoring some of the blit amalgamation didn't regress.
Comment 6 Clemens Eisserer 2012-01-07 13:56:41 UTC
Incredible - I really didn't reccognize gc05e90a == c05e90aa9 ;)

Thanks again.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.