Bug 45094

Summary:	hal 0.5.14 is trying to include internal glib headers
Product:	hal	Reporter:	guido
Component:	hald	Assignee:	David Zeuthen (not reading bugmail) <zeuthen>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	medium	CC:	rohit000, vangel.attila
Version:	unspecified
Hardware:	All
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	simplied patch to avoid including internal glib headers

Description guido 2012-01-22 10:42:31 UTC

Created attachment 55986 [details] [review]
simplied patch to avoid including internal glib headers

It seems that some of the linux addons from the hal daemon version 0.5.14 are wrongly trying to include some internal glib header files.

I do not know exactly which version of glib has started to forbid the inclusion of internal headers other than <glib.h>, but the attached simplified patch has helped me building the hal daemon.

The error produced by glib is as follows:

#error "Only <glib.h> can be included directly."

An improved patch could #ifdef in order to account the exact glib version so that perhaps hal remains backward-compatible with more obsolete environments.

Comment 1 Attila 2012-05-01 08:44:46 UTC

Hi, sorry for nagging, but I think it's easy to fix and still it's open for more than 3 months. Could you please release a new version, which does not have these compile problems? Would be highly appreciated. :)
It caused problems like:
http://forums.funtoo.org/viewtopic.php?id=1347
and I also ran into it:
https://aur.archlinux.org/packages.php?ID=51454

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.