Bug 45428

Summary: [bisected]oglc accum(basic.accum) sefaults
Product: Mesa Reporter: fangxun <xunx.fang>
Component: Drivers/DRI/i915Assignee: Ian Romanick <idr>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: high CC: brianp
Version: git   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 42993    

Description fangxun 2012-01-31 01:41:31 UTC 
System Environment:
--------------------------
Arch:           x86_64
Platform:       Sugarbay
Libdrm:         (master)2.4.30-18-gb643b0713aefdc0611e47654e88263b53b0de6f5
Mesa:           (8.0)caebd7929dca802ece8ef36b0f85094d66133b57
Xserver:      (server-1.11-branch)xorg-server-1.11.3
Xf86_video_intel: (master)2.17.0
Kernel:   (drm-intel-fixes)a4ea430853b71753103ec693acfc8624bd3e748e

Bug detailed description:
-------------------------
It happens on pineview, Ironlake and Sandybridge. Below oglc cases also sefault:
accum(basic.add)
accum(basic.load)
accum(basic.mask)  
accum(basic.mult)
mustpass(basic.accum)
scissor(basic.allCases)
conditional_render(basic.wait.nv) 
conditional_render(basic.nowait) 
conditional_render(basic.typical) 
conditional_render(advanced.nofbo.nowait) 
conditional_render(advanced.nofbo.readpixels) 
conditional_render(advanced.fbo.queryOnFBO)

Bisect shows b31bfae0db24f2c7c5592fc423bdb221219d0faf is the first bad commit.
commit b31bfae0db24f2c7c5592fc423bdb221219d0faf
Author:     Brian Paul <brianp@vmware.com>
AuthorDate: Mon Jan 16 12:40:01 2012 -0700
Commit:     Ian Romanick <ian.d.romanick@intel.com>
CommitDate: Fri Jan 27 18:02:40 2012 -0800

    intel: derive intel_renderbuffer from swrast_renderbuffer

    Drivers that rely on swrast need to do this, as with swrast_texture_image.
    (cherry picked from commit 9f8ed9d66298e2dc5dff508e3ea723469fe06d93)


Reproduce steps:
----------------
1. start X
2. ./oglconform -z -s -suite all -v 2 -test accum basic.accum
Comment 1 Ian Romanick 2012-01-31 08:42:44 UTC 
We just needed one more cherry pick. :)  Fixed by:

commit 442dc31fa71ec433b2c100ec983a6061e83f7dbd
Author: Eric Anholt <eric@anholt.net>
Date:   Tue Jan 24 15:52:52 2012 -0800

    intel: Fix accum buffer mapping since the swrast rework.
    
    A pure swrast-allocated buffer gets an irb of NULL, so we segfaulted
    in the clear-accum test.  Just look at the swrast renderbuffer pointer
    for handling swrast rbs.
    (cherry picked from commit 42e9936ce6bcac9f863b2f85978489e4f804e927)
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=45428
Comment 2 fangxun 2012-02-02 21:20:45 UTC 
Verified with mesa 8.0 commit 7f5d3f7ed2ac42f00e4f848dd79b6223d95d7877.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.