Bug 45441

Summary: Fix return value of downscale_box_filter()
Product: poppler Reporter: Hib Eris <hib>
Component: cairo backendAssignee: poppler-bugs <poppler-bugs>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: 0001-Fix-return-value-of-downscale_box_filter.patch

Description Hib Eris 2012-01-31 05:44:15 UTC
Going through the warnings while compiling poppler, I noticed the retval
variable in downscale_box_filter() was not used at all. I think it should
actually be used as the return value.

Patch follows.
Comment 1 Hib Eris 2012-01-31 05:45:37 UTC
Created attachment 56384 [details] [review]
0001-Fix-return-value-of-downscale_box_filter.patch
Comment 2 Carlos Garcia Campos 2012-02-04 02:24:12 UTC
Comment on attachment 56384 [details] [review]
0001-Fix-return-value-of-downscale_box_filter.patch

Review of attachment 56384 [details] [review]:
-----------------------------------------------------------------

Pushed, thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.