| Summary: | Add tp_connection_disconnect_async() | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | tp-glib | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | enhancement | ||
| Priority: | medium | Keywords: | patch |
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://cgit.freedesktop.org/~smcv/telepathy-glib/log/?h=disconnect-api-45459 | ||
| Whiteboard: | review+ | ||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 22207 | ||
|
Description
Simon McVittie
2012-01-31 11:54:34 UTC
+ g_simple_async_result_complete_in_idle (result); In what case will tp_cli_connection_call_disconnect return immediately? This is so annoying that we have to do this... Otherwise, looks good. (In reply to comment #1) > In what case will tp_cli_connection_call_disconnect return immediately? If the D-Bus interface is missing (impossible here because it's the core interface) or the proxy has been invalidated (but I might be misremembering that second one, I'll have to check). If I'm right about the second one, I'm pretty sure other places in tp-glib get this wrong. I'll check. Making tp_cli_*_call_* always-async is on my list to be done early for 1.0, even if we end up deleting them and replacing them with GDBus or GAsyncBadgers or whatever before the API actually freezes. The sometimes-sync is allegedly an API guarantee (as in, the tests test it) but I hope nobody relies on it anyway... (In reply to comment #2) > The sometimes-sync is allegedly an API guarantee (as in, the tests > test it) but I hope nobody relies on it anyway... Hilarious! Feel free to merge. Fixed in git for 0.17.4 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.