| Summary: | hw/xfree86/modes/xf86EdidModes.c fails to build: array subscript is above array bounds | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Torsten Kaiser <x11> | ||||||||
| Component: | Server/General | Assignee: | Xorg Project Team <xorg-team> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> | ||||||||
| Severity: | normal | ||||||||||
| Priority: | medium | CC: | ajax, hramrach, jeremyhu, peter.hutterer, walch.martin | ||||||||
| Version: | unspecified | Keywords: | patch | ||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | 2012BRB_Reviewed | ||||||||||
| i915 platform: | i915 features: | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 44202 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Torsten Kaiser
2012-02-04 08:55:54 UTC
A patch was posted here http://lists.x.org/archives/xorg-devel/2011-November/027176.html but it seems that nobody replied. Created attachment 56770 [details] [review] Fix access to EstIIIModes[] I would prefer this patch. It solves my compile error and the resulting X server works for me. (I'm using it to post this comment...) (In reply to comment #2) > Created attachment 56770 [details] [review] [review] > Fix access to EstIIIModes[] > > I would prefer this patch. > It solves my compile error and the resulting X server works for me. (I'm using it to post this comment...) This patch is cleaner and corrects the off-by-one error, whereas the patch given in comment #1 does not. Is this still an issue for you? If so, please send your patch to xorg-devel for review. Yes, the issue still exists and it is for example popping up in Gentoo: https://bugs.gentoo.org/show_bug.cgi?id=405139 https://bugs.gentoo.org/show_bug.cgi?id=420127 The Gentoo-Fix for 1.11 is currently to automatically downgrade from -O3 to -O2, for 1.12 they added my patch. I will post it to the mailing list. Patch send to mailing list 14 days ago: http://lists.freedesktop.org/archives/xorg-devel/2012-June/031660.html No reaction, but I hope that means nobody has (serious) problems with it. Please followup on the list. I've been on honeymoon for the past 2 weeks and have quite a backlog to churn through. Hopefully someone can get to it before I do. Created attachment 63875 [details] [review] Fix above array bounds error Split the two issues into separate patches, suggesting from Peter Hutterer on the xorg-devel ml. Created attachment 63876 [details] [review] Patch for the second issue: the skipped modes Comment on attachment 63875 [details] [review] Fix above array bounds error Review of attachment 63875 [details] [review]: ----------------------------------------------------------------- I'd slightly prefer to do this by bounds-checking m itself, but this is fine too. Reviewed-by: Adam Jackson <ajax@redhat.com> Comment on attachment 63876 [details] [review] Patch for the second issue: the skipped modes Review of attachment 63876 [details] [review]: ----------------------------------------------------------------- Reviewed-by: Adam Jackson <ajax@redhat.com> Patches have been committed to the xserver git tree, closing as RESOLVED/FIXED Thanks everyone! commit f27fcb81c4a30cec899628e4bb3e300edbcebe4b and commit 738e55ebbdf516a45b95761b815bed4e697dc726 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.