Bug 45638

Created attachment 56616 [details] [review]
0001-Add-a-configuration-option-for-the-test-data-dir.patch

I don't like this patch, the poppler-test clone needs to be inside the test folder like it has always been if you want distcheck to succeed.

This just adds extra complexity to the autohell system and that is something i'd prefer not to do.

(In reply to comment #2)
> I don't like this patch, the poppler-test clone needs to be inside the test
> folder like it has always been if you want distcheck to succeed.

Hhmmm, I seem not to be able to figure out myself how to get 'make distcheck' working with the current sources. Do you have a recipe to do it? Something like:

git clone git://git.freedesktop.org/git/poppler/poppler
cd poppler
git clone git://git.freedesktop.org/git/poppler/test
./configure
make
make check
make distcheck

... but than in some order that it actually works?

(I actually created the patch here because I could not get it to work otherwise, but if it can be done without adding the complexity, so much the better).

Actually i cheat

./autogen.sh --enable-gtk-doc
make
make distcheck
in a separate shell
  cd version-foo/test
  sudo ln -s ../../../test/unittestcases/ .
  sudo ln -s ../../../test/tests/ .
  cd ..
  cd ..
  wait for compilation to finish
  make distclean

(In reply to comment #4)
> Actually i cheat

Shame on you! ;-)

But seriously, you like that better then my patch?

I just don't like new autoconf code and just adds a lot.

But as i see i'm not going to convince you, please write the test dir that will be used in the summary. Also write a similar note to the one you are writing for autoconf for cmake, since make test runs the tests too.

Created attachment 56643 [details] [review]
0001-Add-a-configuration-option-for-the-test-data-dir.patch

Updated patch adding testdatadir to config summary and adding testdatadir tests and instructions for cmake.

On hold until xpdf303merge branch is merged next week.

Commited to master