Bug 45757

Summary: [bisected] oglc mustpass(basic.proxyTexture) regressed
Product: Mesa Reporter: fangxun <xunx.fang>
Component: Drivers/DRI/i915Assignee: Anuj Phogat <anuj.phogat>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: high CC: anuj.phogat
Version: git   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 42993    
Attachments: patch for bug 45727
patch for bug 45757

Description fangxun 2012-02-07 22:36:38 UTC 
System Environment:
--------------------------
Arch:           x86_64
Platform:       Sugarbay
Libdrm:         (master)2.4.31
Mesa:           (8.0)65b500857ef9ab8b6bd16bc80e7c9cc869f35750
Xserver:                (server-1.11-branch)xorg-server-1.11.3
Xf86_video_intel: (master)2.17.0-631-g1467a4ba1a327877026cc76b3eabeb51d1415509
Kernel: (drm-intel-fixes)c898261c0dad617f0f1080bedc02d507a2fcfb92

Bug detailed description:
------------------------- 
It fails at Mesa master and 8.0 branch on pineview, Ironlake and Sandybridge . 
Bisect shows b38640082cdf0d271c7d3da83d45dfa5f3a7b8d3 is the first bad commit.
commit b38640082cdf0d271c7d3da83d45dfa5f3a7b8d3
Author:     Anuj Phogat <anuj.phogat@gmail.com>
AuthorDate: Wed Jan 25 19:05:45 2012 -0800
Commit:     Ian Romanick <ian.d.romanick@intel.com>
CommitDate: Thu Feb 2 11:21:20 2012 -0700

    mesa: fix maximum allowed proxy texture size condition

    width, height parameter in glTexImage2D() includes: texture image
    width + 2 * border (if any). So when doing the texture size check
    in _mesa_test_proxy_teximage() width and height should not exceed
    maximum supported size for target texture type.
    i.e. 1 << (ctx->Const.MaxTextureLevels - 1)

    Texture border is anyway stripped out before it is given to intel
    or gallium drivers.

    This patch fixes Intel oglconform test case: max_values
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44970

    Note: This is a candidate for mesa 8.0 branch.


Reproduce steps:
----------------
1. start X
2. ./oglconform -z -s -suite all -v 2 -test mustpass basic.proxyTexture
Comment 1 Anuj Phogat 2012-02-09 13:39:48 UTC 
This is fixed by following commit:

commit ea228d97f811092b9ffcb90565184a7a8f089477
Author: Anuj Phogat <anuj.phogat@gmail.com>
Date:   Wed Jan 25 19:05:45 2012 -0800

    mesa: fix maximum allowed proxy texture size condition
    
    width, height parameter in glTexImage2D() includes: texture image
    width + 2 * border (if any). So when doing the texture size check
    in _mesa_test_proxy_teximage() width and height should not exceed
    maximum supported size for target texture type + 2 * border.
    i.e. 1 << (ctx->Const.MaxTextureLevels - 1) + 2 * border
    
    Texture border is anyway stripped out before it is given to intel
    or gallium drivers.
    
    This patch fixes Intel oglconform test case:
    max_values negative.textureSize.textureCube
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44970
    
    Note: This is a candidate for mesa 8.0 branch.
    
    Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com>
    Reviewed-by: Ian Romanick <idr@freedesktop.org>
    Reviewed-by: Brian Paul <brianp@vmware.com>
Comment 2 Anuj Phogat 2012-02-09 13:42:53 UTC 
Created attachment 56836 [details] [review]
patch for bug 45727
Comment 3 Anuj Phogat 2012-02-10 06:38:01 UTC 
Created attachment 56865 [details] [review]
patch for bug 45757
Comment 4 Anuj Phogat 2012-02-10 06:39:05 UTC 
*** Bug 45873 has been marked as a duplicate of this bug. ***
Comment 5 fangxun 2012-02-15 01:45:43 UTC 
Verified with mesa master branch(4042702591) and mesa 8.0 branch(
65526d54aa2).

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.