| Summary: | PgSQL new DB allow empty Datasource | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Lionel Elie Mamane <lionel> |
| Component: | Database | Assignee: | Jens Carl <j.carl43> |
| Status: | NEW --- | QA Contact: | |
| Severity: | minor | ||
| Priority: | medium | CC: | dr, iplaw67, jmadero.dev, lionel, lo_bugs, sasha.libreoffice |
| Version: | 3.5.0 release | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | EasyHack DifficultyBeginner SkillCpp SkillVcl TopicUI | ||
| i915 platform: | i915 features: | ||
Easy hack? Is your "observation" still applicable for LO 3.6.1 RC1? Hello friends I'm working on it! hugs Anderson, are you still working on it? Any chance to see a patch arise from your work? I would gladly review it. In order to limit the confusion between ProposedEasyHack and EasyHack and to make queries much easier we are changing ProposedEasyHack to NeedsDevEval. Thank you and apologies for the noise Hey, I would like to take this bug, but I some questions before I can start: Is it still valid to have an empty string for the connection? The dlg now resides dbaccess/source/ui/dlg? The described behaviour still occurs in current master. Jens Terribly sorry it took me so long to respond. (In reply to comment #6) > I would like to take this bug, but I some questions before I can start: > Is it still valid to have an empty string for the connection? Yes. That's a PostgreSQL feature. > The dlg now resides dbaccess/source/ui/dlg? Yes, AFAIK the code handling that dialog is still there. The dialog itself is the .src/.hrc file, and the .cxx files contain the C++ code that implements the actual actions behind the dialog. > The described behaviour still occurs in current master. Yes, as can trivially be checked by "New Database" / Connect to an existing / PostgreSQL / Next, notice that the "Next" field is greyed out until one enters something in "Datasource URL". Adding self to CC if not already on |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
With PostgrSQL, an empty Datasource URL is perfectly valid (connect to localhost / UNIX socket). The "new database wizard" (choose "connect to an existing database", PostgreSQL and "next") requires something, even if only a space character. Change it to allow empty. It happens in source/ui/dlg/ConnectionPage{Setup,}.cxx