Bug 45911

reproduced in 3.5.1 on Fedora 64 bit and Windows XP and 7 32 bit
not reproducible in 3.3.4 on Fedora, therefore regression

Created attachment 62502 [details]
Bug 45911 - WinDbg session with FAILED_SOURCE_CODE

Confirmed with:
LO 3.5.4.2 
Build ID: own W7 debug build
Windows 7 Professional SP1 64 bit

Crash upon exiting #1 instance of Impress.

Attached full WinDbg session with FAILED_SOURCE_CODE.

Attaching OSX crash log - See same crash following these instructions.  I did move several slides before saving and closing both files.

OSX 10.6.8
LibreOffice 3.5.3.2 
Build ID: 235ab8a-3802056-4a8fed3-2d66ea8-e241b8

Created attachment 62506 [details]
OSX Crash Report using LibreOffice 3.5.3.2

*** Bug 45319 has been marked as a duplicate of this bug. ***

Created attachment 63982 [details]
bt + console msgs on master

On pc Debian x86-64, with master sources updated today, I reproduced the problem.

I attached console logs + bt

reproduced on 3.6.3.2

Thanks for attitonal testing
"Version" is most old version where bug first time appears. Not current version of LO. Changing back to 3.4.5 release

Created attachment 69486 [details]
bt with master

On pc Debian x86-64 with master sources updated yesterday, I reproduced the problem.

Caolán: with 3.6 sources, cherrying picking this commit seems to solve the problem:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=7887a4e0adb0d60e6b013808dc27eccddd1c0324

On master sources, I've got the crash when I close instance 2 and retrieved the last bt.
I noticed that this patch prevents it:
diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index 6d5c36d..fc580db 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -8541,7 +8541,7 @@ uno::Reference< XClipboard > Window::GetPrimarySelection()
             return pChild->GetAccessible();
     }
     */
-    if ( !mpWindowImpl->mxAccessible.is() && bCreate )
+    if ( mpWindowImpl->mxAccessible.is() && bCreate )

What's your idea about all this?

Sorry, patch is wrong obviously :(

Could this be related to bu#51023# - and/or does it persist in 3.6.4 ? :-)

Reproduced on 3.6.4.3  (linux)
Version 3.6.4.3 (Build ID: 2ef5aff

$ cat /opt/libreoffice3.6/program/versionrc
[Version]
AllLanguages=en-US
BuildVersion=
buildid=2ef5aff-a6fb0ff-166bdff-cf087ad-0f1389
ExtensionUpdateURL=http://updateexte.libreoffice.org/ExtensionUpdateService/check.Update
ProductBuildid=3
ProductMajor=360
ProductMinor=1
ProductSource=OOO360
ReferenceOOoMajorMinor=3.4
UpdateID=LibreOffice_3_en-US
UpdateURL=http://update.libreoffice.org/check.php?pkgfmt=deb
UpdateUserAgent=<PRODUCT> (${buildid}; ${_OS}; ${_ARCH}; BundledLanguages=${AllLanguages})
Vendor=The Document Foundation

Replicated in Windows version of Version 3.6.4.3 (Build ID: 2ef5aff) as well.

I can reproduce on 3-6, I can't reproduce on 4-0 and, like julien suggests, after cherry-picking 7887a4e0adb0d60e6b013808dc27eccddd1c0324 it doesn't crash anymore and valgrind is warning free about it.

Given that its fixed in 4.0 I'll mark this as resolved. Patch now proposed for 3-6 on gerrit.

Caolan McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-3-6":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=72980e72a2d380d5e5a9c7b56a8df0a3ac1e93d0&h=libreoffice-3-6

Resolves: fdo#45911 rhbz#846775 Clipboard must be disposed before Selection


It will be available in LibreOffice 3.6.5.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

Created attachment 72856 [details]
Bug 45911 - WinDbg session with FAILED_SOURCE_CODE

Confirmed with:
LO 4.0.0.1
Build ID: own W7 debug build
Windows 7 Professional SP1 64 bit

Impress still crashes while copying slide between instances.

Attached full WinDbg session with FAILED_SOURCE_CODE.

*** Bug 59731 has been marked as a duplicate of this bug. ***

How about now in the 4.1.X releases, I'm sure we fixed something similar there.

Appears fixed in 4.1.1.2 (windows).

On pc Debian x86-64 with LO 4.1.1.2 Debian package, it doesn't crash too.
So it seems resolved now. 
Caolán: thank you for having pointed this one.
jkonecny: thank you for the test on Windows.

If someone reproduces this, please don't hesitate to reopen this tracker.

No big deal but shouldn't this be "fixed" instead of "worksforme"?

jkonecny: I put WFM because there's no specific fix(es) known for this tracker.

Thanks for the clarification.  Sorry for the clutter.