Bug 45937

Summary: Latest xf86-video-ati from git does not build with xorg server 1.11.903
Product: xorg Reporter: Armin K <krejzi>
Component: Driver/RadeonAssignee: xf86-video-ati maintainers <xorg-driver-ati>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Armin K 2012-02-11 11:23:41 UTC 
Making all in src
make[2]: Entering directory `/sources/driver/xf86-video-ati-6.14.99+git20120210/src'
  CC     radeon_dri2.lo
radeon_dri2.c:519:17: error: field 'link' has incomplete type
radeon_dri2.c:523:19: error: field 'reference_list' has incomplete type
radeon_dri2.c: In function 'ListAddDRI2ClientEvents':
radeon_dri2.c:551:5: warning: implicit declaration of function 'list_add' [-Wimplicit-function-declaration]
radeon_dri2.c: In function 'ListDelDRI2ClientEvents':
radeon_dri2.c:564:5: warning: implicit declaration of function 'list_del' [-Wimplicit-function-declaration]
radeon_dri2.c: In function 'radeon_dri2_client_state_changed':
radeon_dri2.c:578:9: warning: implicit declaration of function 'list_init' [-Wimplicit-function-declaration]
radeon_dri2.c:586:13: warning: implicit declaration of function 'list_for_each_entry' [-Wimplicit-function-declaration]
make[2]: *** [radeon_dri2.lo] Error 1
make[2]: Leaving directory `/sources/driver/xf86-video-ati-6.14.99+git20120210/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/sources/driver/xf86-video-ati-6.14.99+git20120210'
make: *** [all] Error 2


If I recall correctly, previous deffinitions of list_* were in xorg/list.h which changed in xorg server 1.11.903 to xorg_list_add ... That's everything I could find out.
Comment 1 Armin K 2012-02-11 12:11:21 UTC 
Hm, I am not sure if it's right way to do, but in src/radeon_dri2.c I changed

"struct list whatever" to struct "xorg_list whatever"

and 

"list_*" stuff to "xorg_list_*".

It compiled. Yet I am unable to test it, because whole server refuses to start.
Comment 2 Michel Dänzer 2012-02-13 02:17:48 UTC 
Fixed in Git.

(In reply to comment #1)
> Yet I am unable to test it, because whole server refuses to start.

Works for me, make sure the dynamic linker picks up libdrm_radeon built from Git.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.