Bug 46431

Summary: [bisected i965] piglit spec/EXT_texture_integer/api-teximage fails on mesa 8.0
Product: Mesa Reporter: fangxun <xunx.fang>
Component: Drivers/DRI/i965Assignee: Chad Versace <chadversary>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: high CC: brianp, chadversary, idr
Version: 8.0   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 42993    

Description fangxun 2012-02-22 00:38:07 UTC 
System Environment:
--------------------------
Arch :     i386
Platform:  Surgabay
Libdrm:		(master)2.4.31
Mesa:		(8.0)fe77fd3983ba3da16ec53c58a790c381b07387ce
Xserver: (server-1.11-branch)xorg-server-1.11.4
Xf86_video_intel:(master)2.17.0-679-gfe6602cbbc4eed1b88ac731a30b46cc970ea444f
Kernel:	(drm-intel-fixes) 617cf884810b44384fe8e9431e9babeb80a2ff37


Bug detailed description:
------------------------- 
It fails at mesa 8.0 branch on sandybridge and Ironlake. Bisect shows it is piglit test suite changes that caused the failure.  Though the same piglit change, it passes on mesa master branch. I think the failure maybe related to mesa 8.0 driver. If you think this is not driver bug, you can close it.
 
commit 19f34bf1338cfc4a93d777564aedb0bf805140d5
Author: Brian Paul <brianp@vmware.com>
Date:   Wed Feb 15 15:36:18 2012 -0700

    texture_integer-api-teximage: fix / add error checks

    The previous glTexSubImage2D() test could generate either GL_INVALID_ENUM
    or INVALID_OPERATION depending on the order in which glTexSubImage did its
    error checks of this call.

    Replace that call with new calls that can only generate invalid operation
    or invalid enum.

    Plus, add a test for glCopyTexImage2D().


Reproduce steps:
----------------
1. start X
2. ./ext_texture_integer-api-teximage -auto -fbo
Comment 1 Gordon Jin 2012-03-31 18:24:51 UTC 
Ian, any idea?
Comment 2 Chad Versace 2012-06-13 15:42:48 UTC 
Cherry-picking the following commits to 8.0 fixes the bug.

  2ea1522 mesa: allow exposing GL3 without EXT_texture_integer
  d95aded mesa: new _mesa_error_check_format_and_type() function

I have posted a branch with those cherry-picks, along with one additional related change.

  git://people.freedesktop.org/~chadversary/mesa.git bug-46431

The additional cherry-pick is

  b7174bf mesa: add missing GL_UNSIGNED_INT_10F_11F_11F_REV case

Ian and Brian, does this branch look good to you?
Comment 3 Chad Versace 2012-06-20 12:54:19 UTC 
Fixed on mesa-8.0 by these two commits.

1af70e4 mesa: allow exposing GL3 without EXT_texture_integer
af47c32 mesa: new _mesa_error_check_format_and_type() function
Comment 4 lu hua 2012-06-24 19:12:21 UTC 
Verified. It has been fixed on mesa 8.0 branch, commit :d715d3f4a82463a00

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.