Bug 4686

Summary: comb effect with nv driver (GeForce Fx 5200)
Product: xorg Reporter: Martin Pitt <martin.pitt>
Component: Driver/nVidia (open)Assignee: Aaron Plattner <aplattner>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: high CC: brice.goglin, bruno.roggeri, vinyl
Version: 6.8.2   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
screenshot
none
screenshot how it should actually look like none

Description Martin Pitt 2005-10-04 14:38:30 UTC
Hi!

I have an nVidia GeForce Fx 5200 card and use the nv driver. Normal display
works fine, but when I play a video with the xv backed, I get a big "comb"
effect when I scale the movie to a size that comes close to the screen size.
Normal size works fine, but in full screen mode, the picture is totally destroyed.

(The proprietary nvidia driver works well, but has its own deficiencies, so I'd
rather stay with nv).

I will attach a screenshot that demonstrates the effect.
Comment 1 Martin Pitt 2005-10-04 14:42:44 UTC
Created attachment 3483 [details]
screenshot

This shows a fraction of the video; this was taken with a digital camera since
screen capture does not work with xv, so please excuse the poor quality. One
can clearly see the "comb" effect that totally destroys the picture.
Comment 2 Martin Pitt 2005-10-04 14:44:22 UTC
Created attachment 3484 [details]
screenshot how it should actually look like

this is the same part of the movie frame with the x11 driver (how it should
actually look like)
Comment 3 Martin Pitt 2006-01-08 00:51:46 UTC
For the record, this is still true with the latest version (1.0.1.5).

Also, the screen flickers (I get thin horizontal black lines of varying length)
whenever I press a key. That drives one crazy after some hours. 

So I'm forced to use the proprietary nvidia driver now, which I don't like (it
breaks hibernation and I would rather use the open source drivers which have
worked wonderfully until about half a year ago...)
Comment 4 Dongxu Li 2006-06-22 00:46:54 UTC
This bug still exists for version 1.1.22

Distribution: Gentoo
Driver version: x11-drivers/xf86-video-nv-1.1.2
nvidia model: 01:00.0 VGA compatible controller: nVidia Corporation NV34M
[GeForce FX Go5200] (rev a1)
Comment 5 Daniel Stone 2007-02-27 01:28:18 UTC
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 6 Aaron Plattner 2007-05-22 09:50:43 UTC
*** Bug 11006 has been marked as a duplicate of this bug. ***
Comment 7 Aaron Plattner 2007-05-22 09:52:11 UTC
For reference, in bug #11006 Brice Goglin suggested this patch:

--- xserver-xorg-video-nv-2.0.2/src/nv_dac.c 2007-04-14 06:20:28.000000000
+0200
+++ xserver-xorg-video-nv-2.0.2.patched/src/nv_dac.c 2007-05-20
16:23:55.000000000 +0200
@@ -119,6 +119,8 @@
        horizStart = horizTotal - 5;
        horizEnd = horizTotal - 2;   
        horizBlankEnd = horizTotal + 4;    
+       if(pNv->Architecture == NV_ARCH_30)
+          horizTotal += 2;
     }

     pVga->CRTC[0x0]  = Set8Bits(horizTotal);
Comment 8 Johannes Tysiak 2007-05-22 10:04:46 UTC
Thanks for marking the dupe. For further information about the patch see the Debian BTS:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=425279
Comment 9 Martin Pitt 2007-05-22 22:30:03 UTC
You made my day! The patch works perfectly for my NV34 (GeForce Fx 5200), seems that the "== NV_ARCH_30" covers this as well. I can finally use free drivers on my desktop again. :)

I uploaded this patch to the Ubuntu packages, I'll report back any problems with it.
Comment 10 Bruno Roggeri 2007-06-02 09:27:59 UTC
*** Bug 7191 has been marked as a duplicate of this bug. ***
Comment 11 Bruno Roggeri 2007-06-02 09:54:21 UTC
I just though that it'd be useful to have a link to the debian bugs where the patch comes from (as they are not linked from the duplicate bugs):

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=425279
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=215997

Comment 12 Bruno Roggeri 2007-06-02 10:18:33 UTC
And now that I actually tested the patch, I'm pleased to say that it "works for me" too, on nVidia Corporation NV36 [GeForce FX Go5700] (rev a1)   [10de:0347]
Comment 13 Aaron Plattner 2007-07-10 11:56:43 UTC
commit ec78618d685759a39d386e9929661037b167fe68
Author: Aaron Plattner <aplattner@nvidia.com>
Date:   Tue Jul 10 11:54:33 2007 -0700

    Bug #4686: Fix a minor GeForceFX + flatpanel + video overlay corruption issue.
    
    This change was originally in XFree86 CVS, nv_dac.c version 1.36 but got
    reverted accidentally.

:100644 100644 e1f0740... 7e8340d... M  src/nv_dac.c

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.