Bug 46948

Created attachment 57996 [details] [review]
show encoding in demo

Show the font encoding in the demo.

Created attachment 57997 [details] [review]
ctrl-q to quit demo

Make ctrl-q quit the demo

Comment on attachment 57995 [details] [review]
add poppler_fonts_iter_get_encoding

Review of attachment 57995 [details] [review]:
-----------------------------------------------------------------

Looks good!

Comment on attachment 57996 [details] [review]
show encoding in demo

Review of attachment 57996 [details] [review]:
-----------------------------------------------------------------

Looks good too, thanks!

::: glib/demo/fonts.c
@@ +165,5 @@
>  				name = "No name";
>  
> +			encoding = poppler_fonts_iter_get_encoding (fonts_iter);
> +			if (!encoding)
> +				encoding = "No encoding";

Maybe this could be just None, since this will look like:

Encoding: No encoding

maybe it's a bit redundant.

Comment on attachment 57997 [details] [review]
ctrl-q to quit demo

Review of attachment 57997 [details] [review]:
-----------------------------------------------------------------

Ok.

Comment on attachment 57997 [details] [review]
ctrl-q to quit demo

Review of attachment 57997 [details] [review]:
-----------------------------------------------------------------

Ok.

::: glib/demo/main.c
@@ +370,5 @@
> +	closure = g_cclosure_new (G_CALLBACK (gtk_main_quit), NULL, NULL);
> +	gtk_accel_group_connect (gtk_accel, gdk_keyval_from_name ("q"),
> +				 GDK_CONTROL_MASK, 0, closure);
> +	g_closure_unref (closure);
> +	gtk_window_add_accel_group (GTK_WINDOW(win), gtk_accel);

hmm, I think gtk_window_add_accel_group takes a reference of the accel_group, so you should probably unref it here

Feel free to push the patches, just make sure you check whether you need to unref the accel group or not. Thanks

pushed