| Summary: | [next] make TpProxy client codegen always-async | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | tp-glib | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | jonny.lamb |
| Version: | git master | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://cgit.freedesktop.org/~smcv/telepathy-glib/log?h=next-idle-calls-46978 | ||
| Whiteboard: | review+ | ||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 31668 | ||
| Attachments: |
[master] Rewrite unsupported-interface to be suitable for the 'next' branch
[next 1/2] TpProxy codegen: always invoke the method via invoke_callback [next 2/2] Always call TpProxy async method callbacks in an idle |
||
|
Description
Simon McVittie
2012-03-05 10:04:16 UTC
Created attachment 58034 [details] [review] [master] Rewrite unsupported-interface to be suitable for the 'next' branch TpDBusDaemon doesn't have optionally-supported interfaces after the removal of Telepathy Properties, so we have to use TpConnection. I took the opportunity to modernize the test and use GTest. (In reply to comment #1) > [master] Rewrite unsupported-interface to be suitable for the 'next' branch Not shown here: the merge into next, which consists of ignoring the changes already made on next, taking the file from master in its entirety, and adding #include "telepathy-glib/reentrants.h". Created attachment 58035 [details] [review] [next 1/2] TpProxy codegen: always invoke the method via invoke_callback Created attachment 58036 [details] [review] [next 2/2] Always call TpProxy async method callbacks in an idle Previously, we made a re-entrant call to the callback if the TpProxy didn't have the interface. Having a method that is "sometimes async" is bad, though: we should follow the GAsyncResult pattern, and have the method return be always-async. In particular, this means we can safely complete a GAsyncResult from the callback, without doing an additional idle. Okay these look good. Thanks, fixed in next. (unsupported-interface test: 0.17.6.) |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.