Bug 4703

Summary: Xft.h includes prototypes for undefined functions
Product: xorg Reporter: Alan Coopersmith <alan.coopersmith>
Component: Lib/XftAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: minor    
Priority: high CC: bgamari, keithp
Version: gitKeywords: patch
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Cleanup patch none

Description Alan Coopersmith 2005-10-06 17:54:34 UTC 
Xft.h includes these two prototypes:

/* xftdir.c */
FcBool
XftDirScan (FcFontSet *set, _Xconst char *dir, FcBool force);

FcBool
XftDirSave (FcFontSet *set, _Xconst char *dir);

but Xft2 doesn't have xftdir.c or any other definitions of them.

(cvsweb shows that xftdir.c was deleted with the comment "Update to Xft version
2", but that's the same comment on the CVS checkin that added the prototypes.)
Comment 1 Erik Andren 2006-06-03 08:27:19 UTC 
I'm attaching a patch that cleans this and some other unnecessary comments.
Comment 2 Erik Andren 2006-06-03 08:28:00 UTC 
Created attachment 5794 [details] [review]
Cleanup patch
Comment 3 Daniel Stone 2007-02-27 01:28:20 UTC 
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 4 Ben Gamari 2008-06-23 17:58:18 UTC 
Is anyone ever going to apply this? Comments?
Comment 5 Julien Cristau 2008-10-25 11:50:03 UTC 
> --- Comment #4 from Ben Gamari <bgamari@gmail.com>  2008-06-23 17:58:18 PST ---
> Is anyone ever going to apply this? Comments?
> 
applied (the hunks that were still relevant, anyway)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.