Bug 4720

Summary: modular xf86-video-* are missing -DXvExtension
Product: xorg Reporter: Jana Saout <jana>
Component: Build/ModularAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: high CC: cedric, dberkholz, herbs, jasmin-bugfd, libv, thomas, tonymurray128
Version: 6.99.99.900 (7.0 RC0)   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 1690    
Attachments:
Description Flags
AH_BOTTOM for all 3 drivers that require XvExtension none

Description Jana Saout 2005-10-09 05:08:03 UTC
The xorg modular video drivers have the wrong Xv ColorKey (plain black) set and
don't support the "VideoKey" config option for example. The reason is that
-DXvExtension that is #ifdef'ed in the source is never set by the build system.
Comment 1 Luc Verhaegen 2005-10-28 04:41:09 UTC
*** Bug 4912 has been marked as a duplicate of this bug. ***
Comment 2 Adam Jackson 2005-11-19 04:47:24 UTC
*** Bug 4224 has been marked as a duplicate of this bug. ***
Comment 3 Steffen Schwientek 2005-11-19 08:31:35 UTC
Can confirm this bug ist still valid for the savage driver and Version RC3  
Comment 4 Luc Verhaegen 2005-11-19 22:16:24 UTC
The way i worked around this in modular unichrome.sf.net code is to define this
locally in the config.h through configure.ac.

Look at
http://cvs.sourceforge.net/viewcvs.py/unichrome/xf86-video-unichrome/configure.ac?rev=1.1&view=log

Lines 58 and 100 are the workaround for this.

I'm not sure wether this is the correct solution though. My current configure.ac
for a start doesn't do a PKG_CHECK_MODULES and i'm not sure wether i dug this
out when i was looking into this.

Twini (who's sitting next to me right now) said he has his driver ignore
XvExtension completely after a certain Xfree86 version. Apparently after 4.3
alanh removed this #ifdeffing from the sis driver and thomas followed that
(while remaining backward compatible).

Ajax, maybe you have a better idea about what should happen here.

Should drivers just depend on Xv being enabled and present?
Comment 5 Daniel Stone 2005-11-21 09:32:34 UTC
it is actually optional in the build; XvExtension should probably go in
xorg-server.h.in.  either that, or we admit that no-one who wants a light DDX
actually uses Xorg and no-one actually bothers not compiling Xv, and make it
mandatory.
Comment 6 Thomas Hellström 2005-11-27 08:28:35 UTC
*** Bug 5067 has been marked as a duplicate of this bug. ***
Comment 7 Cedric Berger 2005-11-28 19:27:02 UTC
Moving Severity from Minor to Major. Not having Video on
Via boxes, which are typically used for media centers, 
is not a minor issue :)

Bug 5067 attachment 3835 [details] [review] (first chunk) is a minimum patch
for the i386 case, but I agree this is not 100%.

Let's fix that one way or another though!
 
Comment 8 Thomas Hellström 2005-11-29 09:05:48 UTC
The following configure.ac snippet should probably do the trick, unless I've
missed something obvious? Also makes sure that videoproto is in.

SAVED_RM="$REQUIRED_MODULES"
XORG_DRIVER_CHECK_EXT(XV, videoproto)
if test "x$REQUIRED_MODULES" != "x"; then
   AC_DEFINE(XvExtension,1,[Enable X Video support])
fi
REQUIRED_MODULES="$SAVED_RM $REQUIRED_MODULES"

Comment 9 Thomas Hellström 2005-11-29 09:12:59 UTC
(In reply to comment #8)
> The following configure.ac snippet should probably do the trick, unless I've
> missed something obvious? Also makes sure that videoproto is in.
> 
> SAVED_RM="$REQUIRED_MODULES"
> XORG_DRIVER_CHECK_EXT(XV, videoproto)
> if test "x$REQUIRED_MODULES" != "x"; then
>    AC_DEFINE(XvExtension,1,[Enable X Video support])
> fi
> REQUIRED_MODULES="$SAVED_RM $REQUIRED_MODULES"
> 

Of course I forgot a
REQUIRED_MODULES=""
between the first and second line.

> 

Comment 10 Luc Verhaegen 2005-11-30 03:50:23 UTC
AH_BOTTOM([
#ifdef XV
#define XvExtension 1
#endif])

Xv is not an absolute requirement in most cases.
Comment 11 Cedric Berger 2005-12-01 03:27:48 UTC
Is there a real patch I could test?
RC3 is getting wrapped up soon, correct?
Comment 12 Luc Verhaegen 2005-12-02 00:32:44 UTC
Created attachment 3961 [details] [review]
AH_BOTTOM for all 3 drivers that require XvExtension

Trivial really. But preferred above an xorg-server.h, as this somewhat forces
drivers to be adapted (post-release), and only a rather meek 3 drivers
apparently are capable of building without Xv support.
Comment 13 Thomas Hellström 2005-12-02 01:11:23 UTC
I agree that this is a good solution.
IMHO we should get this in before RC3.
/Thomas
Comment 14 Kevin E. Martin 2005-12-02 09:04:45 UTC
Comment on attachment 3961 [details] [review]
AH_BOTTOM for all 3 drivers that require XvExtension

I've checked in a different fix that will enable both Xv and XvMC support for
the server and drivers.
Comment 15 Kevin E. Martin 2005-12-02 09:05:27 UTC
Fixed in CVS.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.