Bug 4723

Summary:	broken configure test for pkgconfig version
Product:	cairo	Reporter:	Benny Siegert <bsiegert>
Component:	general	Assignee:	Carl Worth <cworth>
Status:	RESOLVED FIXED	QA Contact:	cairo-bugs mailing list <cairo-bugs>
Severity:	normal
Priority:	high
Version:	1.0.0
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Benny Siegert 2005-10-09 08:47:38 UTC

The check for the pkgconfig version in configure.in is broken. For
pkgconfig versions until 0.17, "Requires" has to be used instead of
"Requires.private". However, the test will never select the older idiom.
The problem is line 470 in configure.in:

case `$PKG_CONFIG --version` in
0.?|0.1[0-7]) PKGCONFIG_REQUIRES="Requires"; ;;
*) PKGCONFIG_REQUIRES="Requires.private"; ;;
esac

The square braces are interpreted as m4 quotes and thus vanish from the
generated configure script. What's more is that the version string has a
third component:

% pkg-config --version
0.15.0

I have noticed that bug #4400 has a patch (id=3494) for this problem.
Please commit this ASAP.

Comment 1 Behdad Esfahbod 2006-06-13 23:36:42 UTC

Correct.  Attachment 3494 [details] needs to be committed, and looks good.

Comment 2 Carl Worth 2006-06-14 04:52:28 UTC

With apologies for the delay, thank you both for your effort here and the
additional patch review.

I'm pushing this fix out now.

-Carl

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.