Summary: | mdimporter module causes mdworker32 to crash | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Chris Murphy <bugzilla> |
Component: | Libreoffice | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | NEW --- | QA Contact: | |
Severity: | critical | ||
Priority: | medium | CC: | dent.ace, iplaw67, smith.kennedy, thb, tml |
Version: | 3.5.3 RC1 | ||
Hardware: | x86-64 (AMD64) | ||
OS: | Mac OS X (All) | ||
See Also: |
https://issues.apache.org/ooo/show_bug.cgi?id=103845 https://bugs.freedesktop.org/show_bug.cgi?id=61010 |
||
Whiteboard: | target:4.3.0 target:4.2.0 | ||
i915 platform: | i915 features: | ||
Attachments: |
crash log 1
crashlog 2 crashlog1 crashlog2 crashlog3 crash log after adding otp file to LO template path lyt-yereblend from templates/layout/lang/de |
Created attachment 58840 [details]
crashlog 2
Created attachment 58841 [details]
crashlog1
Created attachment 58842 [details]
crashlog2
Created attachment 58843 [details]
crashlog3
Can confirm this bug for LibreOffice 3.5.3 on OSX 10.7.4. Renaming the file OOoSpotlightImporter alliviated the problem, however, OOO-files will remaim un-indexed. Importance seems high to me given the number of users using LibreOffice on a Mac Confirming, on OSX 10.8 Mountain Lion. I think this is Thorsten's area ? Alex @Thorsten : your call, I think ? Alex The attached crash logs unfortunately don't really give much hints what the problem in our importer code is/was. Luckily (?), our Spotlight importer code hasn't actually even been invoked after LibreOffice 3.5, I think, so these crashes haven't been seen in more recent versions... I recently noticed that the importer isn't working, because the required symbol in the importer (which is actually a dynamic library) was not exported. And after that was fixed, another problem in the importer that caused it to not actually handle the ODF documents that it is supposed to handle was found and fixed. In my very light testing, it seems to work now. But whether we should dare include a thusly fixed importer it in 4.0.1 or not, I don't know. Can anybody confirm that the Spotlight importer code works in current versions of LibreOffice? Hi Tor, As per my findings today indicated on IRC dev, mdworker32 still sigsevs with the plugin in LO 4.1.3.2, at least on Mavericks, because I don't see any such problem on Mountain Lion, but the crashreport indicates that a particular OTP template file is the reason for this, which I don't have in my production release running on Mountain Lion. Alex The file indicated as suspicious : lyt-yereblend.otp which can be found, among others, in : suse/noarch/libreoffice-templates-presentation-layouts-3.3-1.3.1.noarch.rpm and called in : extras/AllLangZip_accessoriestemplateslayout.mk Oh, wait, there are several different versions of the same file... core/extras/source/premium/templates/layout/lang/de and core/extras/source/premium/templates/layout/lang/en-US with different sizes, groan... OK, so after copying the template into my LO 4132 app share/templates folder, I get 4 crash logs within one minute, whereas before I had none. The suspicious file indicated by the crash log via mdutil -t xxxxxxxx points to: /Users/alex/DevHack/git/libo/core/extras/source/premium/templates/layout/lang/de/lyt-yereblend.otp Created attachment 91709 [details]
crash log after adding otp file to LO template path
Could somebody please attach the problematic lyt-yereblend.otp file to this bug, thanks. If I try to import the metadata from that file from sourceforge, it succeeds. I used the mdimport32 command, see 'man mdimport', as in: mdimport32 -d4 Downloads/lyt-yereblend.otp This is with LibreOffice 4.1.4.2 on Mavericks. I guess it is possible that the copy of the problematic .otp file that I found is different from the one that causes the crash, so please, do attach that. Created attachment 92021 [details]
lyt-yereblend from templates/layout/lang/de
On Mountain Lion 10.8.5 mdimport -d4 /Users/alex/DevHack/git/libo/core/extras/source/premium/templates/layout/lang/de/lyt-yereblend.otp (Debug) Import: file:/Users/alex/DevHack/git/libo/core/extras/source/premium/templates/layout/lang/de/lyt-yereblend.otp plugin:file://localhost/Applications/LibreOffice.app/Contents/Library/Spotlight/OOoSpotlightImporter.mdimporter/ /Applications/LibreOffice.app/Contents/Library/Spotlight/OOoSpotlightImporter.mdimporter 2014-01-14 10:08:29.108 mdimport[2632:707] Error loading /Applications/LibreOffice.app/Contents/Library/Spotlight/OOoSpotlightImporter.mdimporter/Contents/MacOS/OOoSpotlightImporter: dlopen(/Applications/LibreOffice.app/Contents/Library/Spotlight/OOoSpotlightImporter.mdimporter/Contents/MacOS/OOoSpotlightImporter, 262): no suitable image found. Did find: /Applications/LibreOffice.app/Contents/Library/Spotlight/OOoSpotlightImporter.mdimporter/Contents/MacOS/OOoSpotlightImporter: mach-o, but wrong architecture 2014-01-14 10:08:29.110 mdimport[2632:707] Cannot find function pointer MetadataImporterPluginFactory for factory A3FCC88D-B9A6-4364-8B93-92123C8A2D18 in CFBundle/CFPlugIn 0x7fdf2142e020 </Applications/LibreOffice.app/Contents/Library/Spotlight/OOoSpotlightImporter.mdimporter> (bundle, not loaded) (Error) Import: Could not create instance for plugIn 'file://localhost/Applications/LibreOffice.app/Contents/Library/Spotlight/OOoSpotlightImporter.mdimporter/' (Error) Import: BAD IMPORTER ~~~~~~~~~~~~~~~~~~ file://localhost/Applications/LibreOffice.app/Contents/Library/Spotlight/OOoSpotlightImporter.mdimporter/ 2014-01-14 10:08:29.112 mdimport[2632:707] Imported '/Users/alex/DevHack/git/libo/core/extras/source/premium/templates/layout/lang/de/lyt-yereblend.otp' of type 'org.oasis-open.opendocument.presentation-template' with plugIn /Applications/LibreOffice.app/Contents/Library/Spotlight/OOoSpotlightImporter.mdimporter. 2014-01-14 10:08:29.113 mdimport[2632:707] Attributes: { "_kMDItemFinderLabel" = 0; "_kMDItemStaticInterestScore" = "0.1111111"; "com_apple_metadata_modtime" = 305576163; kMDItemContentCreationDate = "2010-09-07 18:16:03 +0000"; kMDItemContentModificationDate = "2010-09-07 18:16:03 +0000"; kMDItemContentType = "org.oasis-open.opendocument.presentation-template"; kMDItemContentTypeTree = ( "org.oasis-open.opendocument.presentation-template", "public.data", "public.item", "public.content" ); kMDItemDisplayName = { "" = "lyt-yereblend.otp"; }; kMDItemKind = { "" = "OpenDocument Presentation Template"; fr = "Mod\U00e8le de pr\U00e9sentation OpenDocument"; }; kMDItemLogicalSize = 784556; kMDItemPhysicalSize = 786432; } macbookpro:~ alex$ Note that I do not appear to have mdimport32 on my system. My understanding of the first part of the output is that it mdimport expects a 64bit importer plugin and that this doesn't happen with current release versions of LO (which are 32bit), hence the mach-o error. As to the rest of the output, I have no idea. Alex Ah ok, well without mdimport32 I guess it is impossible to test the spotlight plug-in from the command line. The LibreOffice.app referenced in the output is : Version: 4.2.0.1 Build ID: 7bf567613a536ded11709b952950c9e8f7181a4a Alex Trying with 64bit dev build importer plugin : mdimport -d4 -g /Applications/LibreOfficeDev.app/Contents/Library/Spotlight/OOoSpotlightImporter.mdimporter /Users/alex/DevHack/git/libo/core/extras/source/premium/templates/layout/lang/de/lyt-yereblend.otp 2014-01-14 10:22:34.483 mdimport[3036:707] loading plugin at path '/Applications/LibreOfficeDev.app/Contents/Library/Spotlight/OOoSpotlightImporter.mdimporter' for all files (Debug) Import: file:/Users/alex/DevHack/git/libo/core/extras/source/premium/templates/layout/lang/de/lyt-yereblend.otp plugin:file://localhost/Applications/LibreOfficeDev.app/Contents/Library/Spotlight/OOoSpotlightImporter.mdimporter/ /Applications/LibreOfficeDev.app/Contents/Library/Spotlight/OOoSpotlightImporter.mdimporter Segmentation fault: 11 OK, with the document from comment #19 I can reproduce the crash using mdimport32, also in a fresh debug build. Let's hope I can find and fix the root cause. Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9e5695543498b71780e73fcf5c18e93487fbd100 fdo#47689: Avoid crashing mdworker: Don't use uninitialized variable The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. (In reply to comment #26) > fdo#47689: Avoid crashing mdworker: Don't use uninitialized variable > Nice catch, thanks ! Alex Tor Lillqvist committed a patch related to this issue. It has been pushed to "libreoffice-4-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2158a26f25b67fdd2564d2e01c2a0a720ef7f2e1&h=libreoffice-4-2 fdo#47689: Avoid crashing mdworker: Don't use uninitialized variable It will be available in LibreOffice 4.2.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Tor Lillqvist committed a patch related to this issue. It has been pushed to "libreoffice-4-2-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b591830c3cba2698aee26b806214e229db4c4483&h=libreoffice-4-2-0 fdo#47689: Avoid crashing mdworker: Don't use uninitialized variable It will be available already in LibreOffice 4.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 58839 [details] crash log 1 During either full Time Machine backups, or full Spotlight rebuilds, mdworker32 process crashes dozens of times, with substantial delays in the backup or rebuild. The crash log implicated org.openoffice.mdimporter in path: /Applications/LibreOffice.app/Contents/Library/Spotlight/OOoSpotlightImporter.mdimporter/Contents/MacOS/OOoSpotlightImporter