| Summary: | Using O_CLOEXEC | ||
|---|---|---|---|
| Product: | fontconfig | Reporter: | Petr Gajdos <pgajdos> |
| Component: | library | Assignee: | Akira TAGOH <akira> |
| Status: | RESOLVED FIXED | QA Contact: | Behdad Esfahbod <freedesktop> |
| Severity: | enhancement | ||
| Priority: | medium | CC: | akira, fontconfig-bugs |
| Version: | 2_1 | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | Using O_CLOEXEC in 2.9.0. | ||
|
Description
Petr Gajdos
2012-03-22 03:58:00 UTC
(This patch created Christian RodrÃguez.) Comment on attachment 58855 [details] [review] Using O_CLOEXEC in 2.9.0. Review of attachment 58855 [details] [review]: ----------------------------------------------------------------- ::: src/fcatomic.c.orig @@ +113,1 @@ > fd = mkstemp ((char *) atomic->tmp); Maybe use the fcntl() equivalent in this case? @@ +115,3 @@ > if (fd < 0) > return FcFalse; > + f = fdopen (fd, "we"); Do other systems just ignore the 'e' modifier transparently? Infact, since this is fdopen as opposed to fopen, I think you don't need the modifier, since the fd is already open. ::: src/fccache.c.orig @@ +216,4 @@ > if (FcStat (cache_file, file_stat) < 0) > return -1; > #endif > + fd = open((char *) cache_file, O_RDONLY | O_BINARY | O_CLOEXEC); Since O_CLOEXEC is a Linux extension, you need ifdef around this I guess? And fall back to the fcntl() equivalent? Looks like we need an internal FcOpen :). @@ +963,4 @@ > if (!FcAtomicLock (atomic)) > goto bail3; > > + fd = open((char *)FcAtomicNewFile (atomic), O_RDWR | O_CREAT | O_BINARY | O_CLOEXEC, 0666); Same here. I'll try to improve this patch ;-]. just for proposed fix: http://cgit.freedesktop.org/~tagoh/fontconfig/commit/?h=bz47705 Hmm, FWIW git-bz seems not working here since a while ago but anyway. committed the changes into git master. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.