Bug 47774

Summary:	Salut should install plugin libraries to a private directory
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	salut	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	jonny.lamb, olli.salli, siraj
Version:	git master	Keywords:	patch
Hardware:	Other
OS:	All
Whiteboard:	review+
i915 platform:		i915 features:
Attachments:	[1/4] Avoid Wocky trying to install into --prefix=NONE [2/4] Avoid non-portable use of += in configure.ac [3/4] Install non-ABI-stable libraries used by plugins to a private directory [4/4] Replace plugindir with an AC_ARG_VAR so it can be passed to configure Compile everything before we test it

Description Simon McVittie 2012-03-23 08:22:20 UTC

Like in Gabble's Bug #46417, Salut should install its non-ABI-stable libraries into a private directory (preventing conflicts over the libwocky.so symlink if Gabble and Salut have incompatible versions of Wocky).

With the patches I'll attach here, you can still do something like this:

    ./configure pluginexeclibdir=/usr/lib/telepathy-android \
         pluginexecdir=/usr/lib/telepathy-android/salut

if you have a controlled environment where Gabble and Salut are carefully kept in sync.

I also fixed a couple of nits in configure.ac which I fixed in Gabble earlier.

Comment 1 Simon McVittie 2012-03-23 08:23:00 UTC

Created attachment 58935 [details] [review]
[1/4] Avoid Wocky trying to install into --prefix=NONE

Comment 2 Simon McVittie 2012-03-23 08:23:13 UTC

Created attachment 58936 [details] [review]
[2/4] Avoid non-portable use of += in configure.ac

Comment 3 Simon McVittie 2012-03-23 08:23:29 UTC

Created attachment 58937 [details] [review]
[3/4] Install non-ABI-stable libraries used by plugins to a  private directory

Comment 4 Simon McVittie 2012-03-23 08:23:44 UTC

Created attachment 58938 [details] [review]
[4/4] Replace plugindir with an AC_ARG_VAR so it can be passed  to configure

Comment 5 Jonny Lamb 2012-03-23 10:18:42 UTC

Yes!

Comment 6 Simon McVittie 2012-03-26 04:40:31 UTC

Created attachment 59058 [details] [review]
Compile everything before we test it

(In reply to comment #5)
> Yes!

Fixed in git for 0.7.2. Tests pass, except avahi/tubes/two-muc-stream-tubes.py and avahi/file-transfer/receive-file-ipv6.py which hang and need to be interrupted (but that doesn't seem to be a regression, they were already broken).

Here's another patch for something that broke while I was testing.

I also had to fix some whitespace to get it to pass tests, but I pushed that unreviewed. I don't like what this says about whether people are even bothering to *try* make check...

Comment 7 Jonny Lamb 2012-03-26 08:58:05 UTC

(In reply to comment #6)
> Created attachment 59058 [details] [review] [review]
> Compile everything before we test it

Looks good.

> I also had to fix some whitespace to get it to pass tests, but I pushed that
> unreviewed. I don't like what this says about whether people are even bothering
> to *try* make check...

:-(

Comment 8 Simon McVittie 2012-05-30 05:00:17 UTC

(In reply to comment #7)
> > Compile everything before we test it
> Looks good.

Fixed in 0.8.0

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.