Bug 47878

Makefile.xvmc points to:

install: default
	$(INSTALL) -d $(DESTDIR)$(INSTALL_DIR)/$(LIB_DIR)
	$(MINSTALL) -m 755 $(TOP)/$(LIB_DIR)/gallium/$(LIB_GLOB) $(DESTDIR)$(INSTALL_DIR)/$(LIB_DIR)


According to "current" file under ./configs:
INSTALL_DIR = $(prefix)
and
prefix = /usr
and
LIB_DIR = x86_64-linux-gnu (in this case)

This explains why it is not installed correctly because it should point to ${libdir}/ or ${libdir}/xvmc instead, where libdir = /usr/lib/x86_64-linux-gnu (or similar according to what is defined).

The solution is to add a XVMC_INSTALL_DIR in Makefile.xvmc and generate that variable in the "current" file. I know "current" is automatically generated, but I still don't know how exactly (going through autogen.sh -> configure -> configure.ac -> configs/* and then ...) If someone could help me on this, I would suggest a patch soon.

Going to dig into it, but I don't have much experience with the install targets also so that could take a while.

Created attachment 59161 [details] [review]
Possible fix.

Fixing the bug in the short hand is actually pretty easy, just replace the obvious incorrect combination of "$(DESTDIR)$(INSTALL_DIR)/$(LIB_DIR)" with "$(DESTDIR)$(INSTALL_LIB_DIR)".

As an alternative you could also add an "--with-xvmc-libdir=" option, which then results in setting the XVMC_INSTALL_DIR variable.

For an good example how to do this take a look at the "--with-vdpau-libdir=" option and the resulting VDPAU_LIB_INSTALL_DIR variable in configure.ac.

Hope that helps,
Christian.

This seems a good solution. My only concern is about the folder: do we want a specific folder as for other trackers?

By the way, thank you for the info about configure.ac

(In reply to comment #3)
> Created attachment 59161 [details] [review] [review]
> Possible fix.
> 
> Fixing the bug in the short hand is actually pretty easy, just replace the
> obvious incorrect combination of "$(DESTDIR)$(INSTALL_DIR)/$(LIB_DIR)" with
> "$(DESTDIR)$(INSTALL_LIB_DIR)".
> 
> As an alternative you could also add an "--with-xvmc-libdir=" option, which
> then results in setting the XVMC_INSTALL_DIR variable.
> 
> For an good example how to do this take a look at the "--with-vdpau-libdir="
> option and the resulting VDPAU_LIB_INSTALL_DIR variable in configure.ac.
> 
> Hope that helps,
> Christian.

It at least sounds like a good idea if vdpau and va have a separate installation-dir parameter to give xvmc one also.

I just doesn't want to do the patch myself, so if you want to hack it together just leave me a note here and then send the patch to the list for review.

Otherwise I'm going to commit the simpler version and close this bugreport.

(In reply to comment #5)
> It at least sounds like a good idea if vdpau and va have a separate
> installation-dir parameter to give xvmc one also.
> 
> I just doesn't want to do the patch myself, so if you want to hack it together
> just leave me a note here and then send the patch to the list for review.
> 
> Otherwise I'm going to commit the simpler version and close this bugreport.

I'll do it in the next couple of days with the help of your explanations.

Created attachment 59455 [details] [review]
XvMC installation directory fix

Please review. This fixes the folder in which XvMC libraries are installed.

Could someone review and commit it if good please? XvMC libs were not installed in the good folder.

Reordered the new macros a bit and comitted the result (http://cgit.freedesktop.org/mesa/mesa/commit/?id=3ea3695b0495a56d9946a292e0e7cad4e0fb2fe0).  Please try to use git's "format-patch" command the next time instead of just supplying a diff (I just hate to write commit messages).

Thanks for the help,
Christian.