Bug 47990

Summary:	[PNV]I-G-T/gem_tiled_after_untiled_blt fail
Product:	DRI	Reporter:	Guang Yang <guang.a.yang>
Component:	DRM/Intel	Assignee:	Daniel Vetter <daniel>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	ben, chris, daniel, florian, jbarnes
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	40928

Description Guang Yang 2012-03-28 02:28:14 UTC

System Environment:
--------------------------
Platform:        Pineview
Kernel: (drm-intel-next-queued)1d83f4426fa0555c98c989915be6df01a8125aca
Bug detailed description:
-------------------------
   On PNV platform ,running gem_tiled_after_untiled_blt of the
Intel-gpu-tools will fail.
  the error on the console is like this:
   filling ring
   playing tricks
   checking
   gem_tiled_after_untiled_blt: gem_tiled_after_untiled_blt.c:197: main:    Assertion `data[i] == i' failed.
   Aborted (core dumped)
   Here is the GDB backtrace:
#0  0xb7fff424 in __kernel_vsyscall ()
#1  0x4105498f in raise () from /lib/libc.so.6
#2  0x410562d5 in abort () from /lib/libc.so.6
#3  0x4104d6a5 in __assert_fail_base () from /lib/libc.so.6
#4  0x4104d757 in __assert_fail () from /lib/libc.so.6
#5  0x0804993a in main (argc=1, argv=0xbffff334) at     gem_tiled_after_untiled_blt.c:197

Comment 1 Chris Wilson 2012-04-03 14:40:15 UTC

commit 7dd4906586274f3945f2aeaaa5a33b451c3b4bba
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Wed Mar 21 10:48:18 2012 +0000

    drm/i915: Mark untiled BLT commands as fenced on gen2/3

    The BLT commands on gen2/3 utilize the fence registers and so we cannot
    modify any fences for the object whilst those commands are in flight.
    Currently we marked tiled commands as occupying a fence, but forgot to
    restrict the untiled commands from preventing a fence being assigned
    before they were completed.

    One side-effect is that we ten have to double check that a fence was
    allocated for a fenced buffer during move-to-active.

    Reported-by: Jiri Slaby <jirislaby@gmail.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=43427
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=47990
    Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
    Testcase: i-g-t/tests/gem_tiled_after_untiled_blt
    Tested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: stable@kernel.org
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Comment 2 Guang Yang 2012-04-15 19:15:39 UTC

tested by guang yang,
the newest -fixes branch include the patch about this bug : 
drm/i915: Mark untiled BLT commands as fenced on gen2/3

Comment 3 Florian Mickler 2012-04-16 14:48:37 UTC

A patch referencing a commit referencing this bug report has been merged in Linux v3.4-rc3:

commit 15a13bbdffb0d6288a5dd04aee9736267da1335f
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Thu Apr 12 01:27:57 2012 +0200

    drm/i915: clear fencing tracking state when retiring requests

Comment 4 Jari Tahvanainen 2017-09-04 10:09:49 UTC

Closing old verified+fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.