Summary: | [Patch] Prevent crash on duplicate module loading | ||
---|---|---|---|
Product: | p11-glue | Reporter: | Andreas Metzler <ametzler> |
Component: | p11-kit | Assignee: | Stef Walter <stefw> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | medium | ||
Version: | unspecified | ||
Hardware: | Other | ||
OS: | Linux (All) | ||
Whiteboard: | |||
i915 platform: | i915 features: |
Description
Andreas Metzler
2012-04-01 04:51:51 UTC
Thanks. The other day I fixed this in git master in a different way. Does this commit fix the issue for you? Please reopen this bug if it doesn't fix the issue. commit ff9926b8dcead91e7fc6d08d0ca1d2d8cc982308 Author: Stef Walter <stefw@gnome.org> Date: Sun Apr 1 21:56:35 2012 +0200 Fix crasher when a duplicate module is present The patch in GIT fixes the crash for me, thanks. What are your thought about the second patch? Could this have a place upstream, or will it need to stay in Ubuntu (and Debian)? cu andreas (In reply to comment #2) > The patch in GIT fixes the crash for me, thanks. > > What are your thought about the second patch? Could this have a place upstream, > or will it need to stay in Ubuntu (and Debian)? > > cu andreas I think it may be worthwhile to limit the module config file names. This however is not a backwards compatible change. Since this is early on in p11-kit usage, we may be able to swing such a change. Could you to post such a patch to the p11-glue mailing list and see if anyone balks. We don't want to have *.dpkg checks upstream. Two reasons: * More and more daemons are moving to files-in-a-directory configuration. If dpkg writes such duplicate files regularly, this is a systemic problem, and not specific to p11-kit. * p11-kit should probably move towards having three directories that it loads config files: 1. /etc/pkcs11/modules (root/admin configured module configs) 2. /usr/lib/p11-kit/modules (module configs installed by packages) 3. ~/.pkcs11/modules (user configured module configs) Stuff in (2) would be expected not to be edited by admins. They could override such things in (1). (2) would be installed to used by packages. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.