Bug 48190

Summary:	configure check for systemd always evaluates as true
Product:	accountsservice	Reporter:	David King <amigadave>
Component:	general	Assignee:	Matthias Clasen <mclasen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	cskeogh, rstrode
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	fix systemd configure test

Description David King 2012-04-02 04:57:13 UTC

There have been a few reports of build failures on the gnome-love mailing list:

http://mail.gnome.org/archives/gnome-love/2012-April/msg00000.html

The check in configure.ac seems to be wrong:

http://cgit.freedesktop.org/accountsservice/commit/?id=753ec1b3dc91a8e93142e69f2daf8f798cb0850b

Specifically:

if test "x$have_systemd" != "no" ; then

which, even when $have_systemd is ‘no’, will always evaluate as if systemd were found (prefixed ‘x’ in the first string but missing in the second string).

Comment 1 David King 2012-04-02 04:58:50 UTC

Created attachment 59372 [details] [review]
fix systemd configure test

Comment 2 Matthias Clasen 2012-04-02 06:30:47 UTC

Thanks, fixed

Comment 3 Ray Strode [halfline] 2012-04-02 11:39:20 UTC

woops

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.