Bug 4837

Summary: [r128] unnecessary warning and error messages in Xorg.0.log
Product: xorg Reporter: Sebastian Marek <s.marek>
Component: Driver/rage128Assignee: Xorg Project Team <xorg-team>
Status: RESOLVED WONTFIX QA Contact: Xorg Project Team <xorg-team>
Severity: enhancement    
Priority: lowest    
Version: 6.8.2   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 3116    

Description Sebastian Marek 2005-10-21 04:01:26 UTC
I'm using a "Rage 128 Pro Ultra TF" Card together with a CRT. I set the Option
"Display" to "CRT" as the man-pages suggests and obviously the info->BIOSDisplay
variable is set correctly, because the line
(**) R128(0): Using external CRT for display
appears, which is fine.

Still, the driver warns me about not specifying panel dimensions and the fact
that no flat panel was found. Yeah, well. There is none, and I told you through
xorg.conf, didn't I? ^^

Looking at the c-file, the flatpanel code fragments are only surrounded by 'if
(info->isDFP)' tests, and isDFP is set to TRUE whenever there is a TF chip like
mine (and others) found. I actually don't have the time to look closer at the
code, but why is isDFP not set to false when BIOSDisplay ==
R128_BIOS_DISPLAY_CRT? Maybe I'm overlooking something and finally it's just two
lines in the logfile. The driver actually does work. But wouldn't an empty
output of grep '^.[W|E]' /var/log/Xorg.0.log be great?

Excerpt from my current /var/log/Xorg.0.log
...
(WW) R128(0): Can't determine panel dimensions, and none specified.         
Disabling programming of FP registers
...
(EE) R128(0): No DFP detected
...

To get this straight: the driver works perfectly, it's just cosmetical logfile
cleaning for me. :)

Btw: when not specifying the Display Parameter in xorg.conf at all, the output
is exactly the same.
Comment 1 Daniel Stone 2007-02-27 01:28:31 UTC
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 2 Jeremy Huddleston Sequoia 2011-10-17 00:30:55 UTC
If you can provide a patch to fixup the logging, please reopen with the patch 
attached (or better yet, email it to xorg-devel for review)... but this driver 
is dated and isn't used my modern hardware

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.