Summary: | screen isn't blank for the DPMS standby and suspend state with external VGA | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | DRI | Reporter: | Ouping Zhang <ouping.zhang> | ||||||
Component: | DRM/Intel | Assignee: | Daniel Vetter <daniel> | ||||||
Status: | CLOSED FIXED | QA Contact: | |||||||
Severity: | normal | ||||||||
Priority: | medium | CC: | ben, chris, daniel, jbarnes | ||||||
Version: | unspecified | ||||||||
Hardware: | x86 (IA32) | ||||||||
OS: | Linux (All) | ||||||||
Whiteboard: | |||||||||
i915 platform: | i915 features: | ||||||||
Attachments: |
|
Description
Ouping Zhang
2012-04-09 23:09:48 UTC
Created attachment 59707 [details]
messages info
To clarify: Is this a regressions? This issue is not a regession. (In reply to comment #2) > To clarify: Is this a regressions? Created attachment 59709 [details] [review] There is no spoon. On drm-intel-next-queued: commit df0323c42ac35f81b49e25fe04e8e52b9c6f6467 Author: Jesse Barnes <jbarnes@virtuousgeek.org> Date: Tue Apr 17 15:06:33 2012 -0700 drm/i915: IBX+ doesn't have separate vsync/hsync controls on the VGA DAC When the PCH split occurred, hw dropped support for separate hsync and vsync disable in the VGA DAC. So add a PCH specific DPMS function that just uses the port enable bit for controlling DPMS states. Before this fix, when anything other than a full DPMS off occurred, the VGA port would be left enabled and scanning out while all the other heads would turn off as expected. v2: duplicate encoder helper vtable into pch and gmch versions (Daniel) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=48491 Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> [danvet: s/intel_crt_dpms/gmch_crt_dpms as suggested by Chris.] Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Kernel: (drm-intel-next-queued)b98e5240b362e702355ffedba05aeb589dfbcbe2 with the above kerenel, I can't reproduced the issue, it has fixed. (In reply to comment #5) > On drm-intel-next-queued: > commit df0323c42ac35f81b49e25fe04e8e52b9c6f6467 > Author: Jesse Barnes <jbarnes@virtuousgeek.org> > Date: Tue Apr 17 15:06:33 2012 -0700 > drm/i915: IBX+ doesn't have separate vsync/hsync controls on the VGA DAC > When the PCH split occurred, hw dropped support for separate hsync and > vsync disable in the VGA DAC. So add a PCH specific DPMS function that > just uses the port enable bit for controlling DPMS states. > Before this fix, when anything other than a full DPMS off occurred, > the VGA port would be left enabled and scanning out while all the other > heads would turn off as expected. > v2: duplicate encoder helper vtable into pch and gmch versions (Daniel) > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=48491 > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> > [danvet: s/intel_crt_dpms/gmch_crt_dpms as suggested by Chris.] > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Closing old verified. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.