Summary: | Fix doc comments for recent stricter gtk-doc | ||
---|---|---|---|
Product: | Telepathy | Reporter: | Stef Walter <stefw> |
Component: | tp-glib | Assignee: | Telepathy bugs list <telepathy-bugs> |
Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
Severity: | normal | ||
Priority: | medium | CC: | stefw |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: |
Fix doc comments for recent stricter gtk-doc
Fix auto-generated gtk-doc constant comment |
Description
Stef Walter
2012-04-12 02:49:30 UTC
Created attachment 59840 [details] [review] Fix doc comments for recent stricter gtk-doc * Build fails with new gtk-doc (1.18.1) which seems to be stricter than previous versions. The warnings aren't fatal; the fatal thing is that g-ir-scanner has also become more strict, and is unconditionally treating warnings as errors. We don't generally fix warnings from newer tool versions on a stable branch (only on master), but since you've made a patch, I'll review it. Fixed in git for 0.18.1, thanks. Already fixed for 0.19 by Jonny (possibly with more fixes). Thanks! jhbuild builds now. Comment on attachment 59840 [details] [review] Fix doc comments for recent stricter gtk-doc Review of attachment 59840 [details] [review]: ----------------------------------------------------------------- ::: tools/c-constants-gen.py @@ -71,1 @@ > %s: I don't think this is right? Created attachment 59859 [details] [review] Fix auto-generated gtk-doc constant comment Ah yes. I removed the line which caused g-ir-scanner to barf, but should have also formatted the comment correctly. (In reply to comment #6) > Fix auto-generated gtk-doc constant comment Also pushed to 0.18. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.