| Summary: | about dialog misses Build ID in Dutch langpack | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Cor Nouws <cno> |
| Component: | Libreoffice | Assignee: | Caolán McNamara <caolanm> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | caolanm, cno |
| Version: | Master old -3.6 | ||
| Hardware: | Other | ||
| OS: | Linux (All) | ||
| Whiteboard: | target:3.6.0 | ||
| i915 platform: | i915 features: | ||
| Attachments: |
screen shot about dialog 120410
Fix scren shot about dialog |
||
|
Description
Cor Nouws
2012-04-13 11:06:34 UTC
obvisouly related to this commit 8a3aae9b694deb2b41157509e84815a5b7fb7655 Hmm.. that is odd, the build ID is in the description (LODev daily##### should be 'LibreOffice') I will have a quick look Ooops sorry, no that is correct, the Build ID is just left off. I will have a look... Created attachment 59977 [details] [review] Fix Okay so I believe this patch should fix the issue. '(Build ID: #####)' should not appear if the build id is empty, however this check obviously didn't work so I have made it check is the [build id trimmed of all spaces] is empty, which should now work - Cor could you test this? Regarding the ESC key, I don't immediately know how to do this, and it isn't strictly a bug (an enhancement) so could you file it as a separate report Cor? Hi Andrew, (In reply to comment #2) > Hmm.. that is odd, the build ID is in the description (LODev daily##### should > be 'LibreOffice') Ah yes, I should have wanred you for that. I allways change the <oooname> in the /share/registry/main.xcd That helpt me to see quickly in which of the many versions I work ;-) (In reply to comment #4) > - Cor could you test this? Not sure. When the patch is pushed to master, we'll see there and also maybe cases different then my local repo will be tested. > Regarding the ESC key, I don't immediately know how to do this, and it isn't > strictly a bug (an enhancement) so could you file it as a separate report Cor? IMO it's a real bug when ESC does not close a dialogue. But OK, here is the separate issue :-) : Bug 48723 - new about dialog does not close with ESC (edit) thanks so far! Andrew Higginson committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f73d26889692599aadaba28db406f430b9af7d8c Resolves: fdo#48659 about dialog misses BuildID Created attachment 60243 [details] scren shot about dialog Alas, is not soved for me in http://dev-builds.libreoffice.org/daily/Linux-x86_10-Release_Configuration/master/current/master~2012-04-17_13.43.52_LibO-Dev_3.6.0alpha0_Linux_x86_install-deb_en-US.tar.gz so reopen *scratches head*, I downloaded http://dev-builds.libreoffice.org/daily/Linux-x86_10-Release_Configuration/master/current/master~2012-04-17_13.43.52_LibO-Dev_3.6.0alpha0_Linux_x86_install-rpm_en-US.tar.gz and I have a build-id listed. Can I get the /opt/lodev3.6/program/versionrc from an affected version please (*) (*) and converting buildid=46e18bc-af20ea3-05f89ef-ae7aae4-186d9e to buildid= in /opt/lodev3.6/program/versionrc "does the right thing" as far as I can see. oh wait, if I install the *Dutch* langpack and start in a dutch locale I see it So, lets force " $BUILDID" at the end of the string if a translations is missing the $BUILDID placeholder, that should take care of it. And the problem goes away when translations are updated anyway. Caolan McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=fd257f9e1936b0bc9bc9116bd73eaa04a7dbd060 Resolves: fdo#48659 force BUILDID placeholder in if missing from translation thanks! verified in version 3.6.0alpha0+ Build ID: 87897ea |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.