Bug 48892

Confirmed with:
LOdev 3.5.3rc1+ 
Build ID: 51648779-22e3d74-d554af7
Windows 7 Professional SP1 64 bit

Results:
„Test”
„Test-- „
„Test – „
„Test --”

Confirmed with 3.6.1.2. Marking as NEW and prioritizing. Please open the other issue up as a new bug as it is different and we try not to lump bugs together.

Minor - Harder to make professional quality work only under incredibly specific situation, even in that situation a simple space corrects problem

Lowest - Very unlikely many users are affected by this.

Hopefully we can get someone to take a look at this one. 

@Patrick: I agree with the second bug as well (confirmed) but it needs to be a separate bug, thanks

//@Patrick: I agree with the second bug as well (confirmed) but it needs to be a separate bug, thanks...//

Reported as Bug 55293

Changed "auto-correct" to "AutoCorrect" in title as that is the actual name of the facility in question and this bug was not showing up in typical searches. I have also made a basic clean-up of the title to more clearly indicate the highly specific nature of this issue. 

It essentially deals with the treatment of correcting a closing quotation mark when in proximity to either an en dash or em dash. The hyphen-minus (U+002D) does not display the indicated behaviour under Linux TDF/LO v4.0.3.3. As per the description given "Test – " (U+2013) or "Test — " (U+2014) if the backspace key is pressed twice to remove the erroneous closing quotation mark and prior space, entering a new closing quotation mark adjacent to the dash again results in an erroneous closing quotation mark.

(In reply to comment #0)
> .....
> 
> Why, you might ask, would a writer insert a space before or after an
> em-dash? Well, I'm glad you asked. This brings me to the next bug. If one
> sets auto-correct to correct two dashes (--) with an em-dash, auto-correct
> only works if the double-dash is discreet (separated from the word it
> follows).
> 
> Test-- :Won't be auto-corrected.
> 
> Test -- :*Will* be auto-corrected - but then one runs into the smart quotes
> bug.

take a look at Bug 55292 - autocorrect does not correct two dashes to em-dash *when dashes are not discreet*

now thanks to wilcard autocorrection this part of the issue is fixed so I wonder if after setting a proper wildcard autocorrect pattern you can get rid of the closing quote issue as well.

you need a 4.4.x master build with Lazlo's fix to test (probably a daily build will be available tomorrow)

Okay, if anyone can provide a link to the master build. Is it here?

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a07425892205ff8951027ea20459b97370d01de6

If so, I've never installed from the mater build. I'm using Debian. I usually wait for an uptodate deb and manually install, but I'm open to instruction.

daily build page is here: http://dev-builds.libreoffice.org/daily/master/

current master should integrate that fix.

Thanks. I've installed it. It starts despite the warnings below. A quick search via Google doesn't find a Debian repository with these dependencies. Since in starts, I'll go ahead and test unless anyone says otherwise, or can recommend a source for the same. 

dpkg: dependency problems prevent configuration of lodevbasis4.4-extension-beanshell-script-provider:
 lodevbasis4.4-extension-beanshell-script-provider depends on lodevbasis4.4-core05 (>= 4.4.0.0.alpha0); however:
  Package lodevbasis4.4-core05 is not installed.
 lodevbasis4.4-extension-beanshell-script-provider depends on lodevbasis4.4-core05 (<= 4.4.0.0.alpha0-1); however:
  Package lodevbasis4.4-core05 is not installed.


dpkg: error processing package lodevbasis4.4-extension-beanshell-script-provider (--install):
 dependency problems - leaving unconfigured
dpkg: dependency problems prevent configuration of lodevbasis4.4-extension-javascript-script-provider:
 lodevbasis4.4-extension-javascript-script-provider depends on lodevbasis4.4-core05 (>= 4.4.0.0.alpha0); however:
  Package lodevbasis4.4-core05 is not installed.
 lodevbasis4.4-extension-javascript-script-provider depends on lodevbasis4.4-core05 (<= 4.4.0.0.alpha0-1); however:
  Package lodevbasis4.4-core05 is not installed.

dpkg: error processing package lodevbasis4.4-extension-javascript-script-provider (--install):
 dependency problems - leaving unconfigured
dpkg: dependency problems prevent configuration of lodevbasis4.4-extension-mediawiki-publisher:
 lodevbasis4.4-extension-mediawiki-publisher depends on lodevbasis4.4-core05 (>= 4.4.0.0.alpha0); however:
  Package lodevbasis4.4-core05 is not installed.
 lodevbasis4.4-extension-mediawiki-publisher depends on lodevbasis4.4-core05 (<= 4.4.0.0.alpha0-1); however:
  Package lodevbasis4.4-core05 is not installed.

dpkg: error processing package lodevbasis4.4-extension-mediawiki-publisher (--install):
 dependency problems - leaving unconfigured
dpkg: dependency problems prevent configuration of lodevbasis4.4-extension-nlpsolver:
 lodevbasis4.4-extension-nlpsolver depends on lodevbasis4.4-core05 (>= 4.4.0.0.alpha0); however:
  Package lodevbasis4.4-core05 is not installed.
 lodevbasis4.4-extension-nlpsolver depends on lodevbasis4.4-core05 (<= 4.4.0.0.alpha0-1); however:
  Package lodevbasis4.4-core05 is not installed.

dpkg: error processing package lodevbasis4.4-extension-nlpsolver (--install):
 dependency problems - leaving unconfigured
dpkg: dependency problems prevent configuration of lodevbasis4.4-extension-pdf-import:
 lodevbasis4.4-extension-pdf-import depends on lodevbasis4.4-core05 (>= 4.4.0.0.alpha0); however:
  Package lodevbasis4.4-core05 is not installed.
 lodevbasis4.4-extension-pdf-import depends on lodevbasis4.4-core05 (<= 4.4.0.0.alpha0-1); however:
  Package lodevbasis4.4-core05 is not installed.

dpkg: error processing package lodevbasis4.4-extension-pdf-import (--install):
 dependency problems - leaving unconfigured
dpkg: dependency problems prevent configuration of lodevbasis4.4-extension-report-builder:
 lodevbasis4.4-extension-report-builder depends on lodevbasis4.4-core05 (>= 4.4.0.0.alpha0); however:
  Package lodevbasis4.4-core05 is not installed.
 lodevbasis4.4-extension-report-builder depends on lodevbasis4.4-core05 (<= 4.4.0.0.alpha0-1); however:
  Package lodevbasis4.4-core05 is not installed.

dpkg: error processing package lodevbasis4.4-extension-report-builder (--install):
 dependency problems - leaving unconfigured
dpkg: dependency problems prevent configuration of lodevbasis4.4-filter-data:
 lodevbasis4.4-filter-data depends on lodevbasis4.4-core05 (>= 4.4.0.0.alpha0); however:
  Package lodevbasis4.4-core05 is not installed.
 lodevbasis4.4-filter-data depends on lodevbasis4.4-core05 (<= 4.4.0.0.alpha0-1); however:
  Package lodevbasis4.4-core05 is not installed.

dpkg: error processing package lodevbasis4.4-filter-data (--install):
 dependency problems - leaving unconfigured
Setting up lodevbasis4.4-gnome-integration (4.4.0.0.alpha0-1) ...
Setting up lodevbasis4.4-graphicfilter (4.4.0.0.alpha0-1) ...
Setting up lodevbasis4.4-images (4.4.0.0.alpha0-1) ...
Setting up lodevbasis4.4-impress (4.4.0.0.alpha0-1) ...
Setting up lodevbasis4.4-kde-integration (4.4.0.0.alpha0-1) ...
Setting up lodevbasis4.4-math (4.4.0.0.alpha0-1) ...
Setting up lodevbasis4.4-ogltrans (4.4.0.0.alpha0-1) ...
Setting up lodevbasis4.4-onlineupdate (4.4.0.0.alpha0-1) ...
Setting up lodevbasis4.4-ooofonts (4.4.0.0.alpha0-1) ...
Setting up lodevbasis4.4-ooolinguistic (4.4.0.0.alpha0-1) ...
dpkg: dependency problems prevent configuration of lodevbasis4.4-python-script-provider:
 lodevbasis4.4-python-script-provider depends on lodevbasis4.4-core05 (>= 4.4.0.0.alpha0); however:
  Package lodevbasis4.4-core05 is not installed.
 lodevbasis4.4-python-script-provider depends on lodevbasis4.4-core05 (<= 4.4.0.0.alpha0-1); however:
  Package lodevbasis4.4-core05 is not installed.

(In reply to comment #5)
> (In reply to comment #0)
> ...
> take a look at Bug 55292 - autocorrect does not correct two dashes to
> em-dash *when dashes are not discreet*
> 
> now thanks to wilcard autocorrection this part of the issue is fixed so I
> wonder if after setting a proper wildcard autocorrect pattern you can get
> rid of the closing quote issue as well.
> 
> you need a 4.4.x master build with Lazlo's fix to test (probably a daily
> build will be available tomorrow)


I've just tested a new 4.4.x daily but that wildcard fix has no effect on the "closing quotes" issue when dealing with these examples.

> "Test-- "  :Smart Quote will reverse the closing quotes.
> "Test -- " :Smart Quote will reverse the closing quotes.

this 3rd case instead will work either with en-dash or em-dash

> "Test --"  :Smart Quote will reverse the closing quotes *if* one has already
> tried to correct the second example by backspacing.

I see correct closing of quotes without hitting backspace.


please retest yourself and give feedback.
info about new wildard autocorrect patterns for en- and em-dash described in detail here: https://bugs.freedesktop.org/show_bug.cgi?id=55292#c19

(In reply to comment #9)
> I've just tested a new 4.4.x daily ...
> 
> please retest yourself and give feedback.
> info about new wildard autocorrect patterns for en- and em-dash described in 
> detail here: https://bugs.freedesktop.org/show_bug.cgi?id=55292#c19

Using attachment 104345 [details] (as per bug 55292) for AutoCorrect, I placed it in my user profile and renamed it to acor_en-AU.dat (my locale) so I can see exactly which entries are being used and confirm that ONLY these entries are being used. Tested under v4.4.0.0.alpha0+ Build ID: 4d635dcae4d7275d04a17a0efc11b0531d5d0a82
TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2014-08-08_23:24:32

Results (trailing character after second quote mark is a SPACE):

“a-- “     to n-dash OK and wrong closing quote NOT OK
“a--- “    to m-dash OK and wrong closing quote NOT OK
“a -- “    to n-dash OK and wrong closing quote NOT OK
“a --- “   to m-dash OK and wrong closing quote NOT OK
“a --”     to n-dash OK and correct closing quote OK
“a ---”    to n-dash+hyphen NOT OK and correct closing quote OK

I see the same closing quotes issues near to en-dash in OOo 3.3 and AOO 4.1 as well, hence the bug is inherited from OOo era.