|
Description
Simon McVittie
2012-05-01 06:39:23 UTC
Created attachment 60836 [details] [review] 01/15] _tp_dbus_starter_bus_conn: remove There's no longer any need to cache a singleton starter bus connection, because the only caller also caches a singleton. --- Not really directly relevant, but it's been sitting on a trivia branch for a while. Created attachment 60837 [details] [review] [02/15] Move TpDebugClient generated code to cli-misc.[ch] and don't document it --- This is the end of Bug #46835, but probably also needed for this one Created attachment 60840 [details] [review] 03/15] Add missing </SECTION> so cli-account-manager docs get generated Created attachment 60841 [details] [review] 04/15] Hide split reentrant methods in documentation Created attachment 60842 [details] [review] 05/15] Hide tp_cli_add_signals functions from documentation Created attachment 60843 [details] [review] 06/15] tp_base_client_get_account_manager: remove from docs, no longer exists Created attachment 60844 [details] [review] 07/15] TpBaseChannelClass: fully remove interfaces member Created attachment 60845 [details] [review] 08/15] TpBaseConnectionCreateChannelFactoriesImpl: fully remove Created attachment 60846 [details] [review] 09/15] tp_presence_mixin_register_with_contacts_mixin: fix documentation Created attachment 60847 [details] [review] 10/15] Remove NUM_TP_* from generated code --- I thought I'd done this already :-( Created attachment 60848 [details] [review] 11/15] Add `make clean-for-new-branch` --- I think this is appropriate to call when switching branch and keeping the same builddir. distclean is too much (you lose your configure options), but clean isn't enough. This should ideally go into master and even 0.18 too. Created attachment 60849 [details] [review] 12/15] Update documentation structure for TpContact features Created attachment 60850 [details] [review] 13/15] Resync sections.txt with this version of telepathy-spec Created attachment 60851 [details] [review] 14/15] Mark private headers as such in the header This means we don't have to remember to list them all in docs/reference/Makefile.am, which seems like a win. We still need to list proxy-introspectable.h, which is a bit of a special case. --- I'll apply a similar change to master at some point. Created attachment 60852 [details] [review] 15/15] Provide introductory doc-comments for all the new cli-* sections Comment on attachment 60849 [details] [review] 12/15] Update documentation structure for TpContact features Review of attachment 60849 [details] [review]: ----------------------------------------------------------------- ::: docs/reference/telepathy-glib-sections.txt @@ +3819,5 @@ > +tp_contact_get_feature_quark_contact_groups > +tp_contact_get_feature_quark_contact_info > +tp_contact_get_feature_quark_location > +tp_contact_get_feature_quark_presence > +tp_contact_get_feature_quark_subscription_states Huh did I not do this? Sorry about that. Well I was scared of there being fifteen patches to review but it was trivial enough. Gogogogogo. (In reply to comment #11) > 11/15] Add `make clean-for-new-branch` ... > This should ideally go into master and even 0.18 too. I merged this one via 0.18 and master, and the rest straight into next. (In reply to comment #14) > 14/15] Mark private headers as such in the header ... > I'll apply a similar change to master at some point. I'd still like to do this, so I'll leave this bug open for now. (In reply to comment #18) > > 14/15] Mark private headers as such in the header > ... > > I'll apply a similar change to master at some point. Now part of Bug #49384, so I'll close this one. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.