Bug 49348

Summary: contact-based Group API does not process removals correctly
Product: Telepathy Reporter: Simon McVittie <smcv>
Component: tp-glibAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED MOVED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium    
Version: git master   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Simon McVittie 2012-05-01 10:53:33 UTC 
ids = tp_asv_get_boxed (details, "contact-ids",
      TP_HASH_TYPE_HANDLE_IDENTIFIER_MAP);
  if (ids == NULL)
    {
      DEBUG ("CM did not give identifiers, can't create TpContact");
      return;
    }

... but it's entirely normal for a group membership change that is just a removal, not an addition, to not provide any contact identifiers at all.

This results in the sets of contacts not being reliably correct, which is pretty bad if we're going to deprecate the sets of handles.

Having fixed that, I still get

ERROR:/home/smcv/src/fdo/tpglib/tests/dbus/group-mixin.c:452:in_the_desert: assertion failed (members->len == 2): (3 == 2)

when I try to use the contacts as my only group API for the tests, so I don't know quite what's going on here.

I think this indicates that we don't have enough test coverage for the contact-based group API.
Comment 1 GitLab Migration User 2019-12-03 20:39:58 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-glib/issues/91.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.