| Summary: | [bug] Image fullscreen is masked with cairo-gl | ||
|---|---|---|---|
| Product: | Wayland | Reporter: | ZhaoShengyan <shengyanx.zhao> |
| Component: | weston | Assignee: | Wayland bug list <wayland-bugs> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
The small part is the canvas of weston, most of the rest is covered.
patch image client back trace |
||
I don't think we have this problem anymore and I've just pushed a few commits to fix a few corner cases around image client fullscreen. Does this still happen with master? Yes, this is still an issue on master w/cairo-gl: cairo (master) 66625cb46c985321c46b79d2163a4d676d6700ba weston (master) e77d7577a25b5eb5c6bc79a9ce0ea335a4df6508 cairo built with --enable-xcb --disable-gtk-doc --enable-gl If you click and drag after setting the image window to fullscreen, the image redraws and fixes itself. Created attachment 69347 [details] [review] patch (In reply to comment #3) > If you click and drag after setting the image window to fullscreen, the > image redraws and fixes itself. I too noticed the image client doesn't particularly exhibit desired bahavior. This patch should improve the image client behavior dramatically, especially for resizing and fullscreen toggling. This might have been done in a widget resize handler but I'm not sure it would be any different than what this patch does. Comment on attachment 69347 [details] [review] patch Review of attachment 69347 [details] [review]: ----------------------------------------------------------------- I tested this patch... it does not fix the clipping/masked issue described in this bug report. However, after clicking and dragging (the workaround), the image now scales with fullscreen and fills the viewport surface nicely. If you go fullscreen with <F11>, there is no issue. The issue is only seen when going fullscreen via the context menu. Created attachment 69372 [details] image client back trace (In reply to comment #6) > If you go fullscreen with <F11>, there is no issue. The issue is only seen > when going fullscreen via the context menu. Ah, that does make a big difference. If I fullscreen with the titlebar menu I am able to reproduce the problem. I found if I drag on the black fullscreened area, I am able to crash the image client easily. I have attached a bt for it. ./image fulscreen on cairo gl works both with <F11> and context menu. cairo: 1.12.8-48-g9194904 drm: libdrm-2.4.40-5-gbaf0a7d kmscon: kmscon-6-109-g4f8edb3 libxcb: 1.9 libxkbcommon: xkbcommon-0.2.0-27-gbb620df mesa: snb-magic-13807-g2f358fe mtdev: e5eb274 pixman: pixman-0.28.0-47-g480dd38 wayland: 1.0.1-14-g812bd4d weston: 1.0.0-228-gedc51c0 xf86-video-intel: 2.19.0-27-g1c65dd7 xf86-video-wlshm: af6618a xserver: xorg-server-1.12.2-104-g5569c0e Marking as fixed Min, could you please help us verify the bug and mark the bug as Verified? cause we don't have the environment now. (In reply to comment #8) > ./image fulscreen on cairo gl works both with <F11> and context menu. > cairo: 1.12.8-48-g9194904 drm: > libdrm-2.4.40-5-gbaf0a7d kmscon: kmscon-6-109-g4f8edb3 libxcb: > 1.9 libxkbcommon: xkbcommon-0.2.0-27-gbb620df mesa: > snb-magic-13807-g2f358fe mtdev: e5eb274 pixman: > pixman-0.28.0-47-g480dd38 wayland: 1.0.1-14-g812bd4d weston: > 1.0.0-228-gedc51c0 xf86-video-intel: 2.19.0-27-g1c65dd7 xf86-video-wlshm: > af6618a xserver: xorg-server-1.12.2-104-g5569c0e Marking as > fixed ZhaoShengyan - going to mark this 'verified'. Reopen if the issue still exists for you. Seems okay on my end.
Linux 3.9.8-100.fc17.x86_64 #1 SMP Thu Jun 27 19:19:57 UTC 2013 x86_64 GNU/Linux
* wayland (master) 1.2.0-0-g6ef06ad
* cairo (HEAD) 1.12.14-0-g0dac37c
- built with --enable-gl
* mesa (9.1) heads/9.1-0-g26f802d
* weston (master) 1.2.0-0-ga684b5a
|
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 60889 [details] The small part is the canvas of weston, most of the rest is covered. System Environment: -------------------------- Arch: i386 Libdrm: (master) 2.4.33-15-g754655c795fff1c6267d358e54ad5198aee0cdd6 Wayland: (master)35fc72eb8b967499332aaf1e3cf20232b7a7efac Mesa: (master)83a02427e576a5126a618c13bc3e12ff2b4a3e0a Xserver:(master)xorg-server-1.12.0-125-gf3410b97cf9b48a47bee3d15d232f8a88e75f4ef Xf86_video_intel:(master)2.19.0-2-g7e09babb3e9e23882db30ee7d0c22c503962faa9 Cairo: (master)db4ee947c3fc2c057dd8e84cdfcb779e7c62e5d5 Cairo_gl: (master)db4ee947c3fc2c057dd8e84cdfcb779e7c62e5d5 Xkbcommon: (master)3d672fcfea6b823db4793b9ad1c3aadc4b547a08 Weston: (master)4577adce8cb547d390a2cbea9e9f9e73eab1b8c2 Kernel_unstable(drm-intel-next-queued)caa3586d5a51a50078c63d87a403117c4297dabe Bug detailed description: ----------------------------- Execute image binary with cairo gl, it showed picture normally. However, when fullscreen it, only a small part of the picture was showed, most of the rest is masked. This can reproduced with cairo gl under both X and drm mode. It doesn't happen with cairo image. Reproduce steps: ---------------------------- 1. start weston with cairo-gl 2. ./image ../wayland-screenshot.png 3. fullscreen it.