|Summary:||Submit AST2000 Graphics Driver|
|Product:||xorg||Reporter:||Y.C. Chen <yc_chen>|
|Component:||Driver/other||Assignee:||Xorg Project Team <xorg-team>|
|Status:||RESOLVED FIXED||QA Contact:|
|Priority:||high||CC:||alan.coopersmith, alexdeucher, carl.switzky, mharris, sndirsch, yc_chen|
|i915 platform:||i915 features:|
|Bug Depends on:|
Description Y.C. Chen 2005-10-31 18:48:16 UTC
New Develop by ASpeed Tech.
Comment 1 Y.C. Chen 2005-10-31 18:49:41 UTC
Created attachment 3673 [details] The source code of AST2000 Graphics Drivers
Comment 2 Adam Jackson 2005-11-01 14:07:32 UTC
can you confirm the license that this should be released under? currently only one file has any copyright or license statements, and those appear to have been inherited from the chips(4) driver.
Comment 3 Y.C. Chen 2005-11-01 19:58:02 UTC
Thanks for your reply! In fact, we develop this driver(ast.h & ast_driver.c) base on chips firstly and reference i810 & sis also. Does any member have any comment for the copyright!? How to do is better!?
Comment 4 Adam Jackson 2005-11-02 12:49:58 UTC
Ideally, every source file (.c or .h) would have a copyright and license statement at the top of the file. For example (from chips/ct_accel.c): /* * Copyright 1996, 1997, 1998 by David Bateman <email@example.com> * Modified 1997, 1998 by Nozomi Ytow * * Permission to use, copy, modify, distribute, and sell this software and its * documentation for any purpose is hereby granted without fee, provided that * the above copyright notice appear in all copies and that both that * copyright notice and this permission notice appear in supporting * documentation, and that the name of the authors not be used in * advertising or publicity pertaining to distribution of the software without * specific, written prior permission. The authors makes no representations * about the suitability of this software for any purpose. It is provided * "as is" without express or implied warranty. * * THE AUTHORS DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE, * INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS, IN NO * EVENT SHALL THE AUTHORS BE LIABLE FOR ANY SPECIAL, INDIRECT OR * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, * DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER * TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR * PERFORMANCE OF THIS SOFTWARE. */ The copyright line should be modified to reflect the owner of the code - probably ASpeed Tech - and the year of authorship. We generally prefer MIT-style licenses, a template can be found at: http://www.opensource.org/licenses/mit-license.php
Comment 5 Y.C. Chen 2005-11-02 20:13:37 UTC
Created attachment 3686 [details] Update the source of AST2000 Graphics Driver Add copyright & license
Comment 6 Adam Jackson 2005-11-04 08:58:19 UTC
excellent, thanks! unfortunately the tree is closed to new drivers until 7.0 is released (scheduled for December 7), but i'll be happy to add it to the driver collection as soon as possible. will you need a CVS account to keep the driver up to date?
Comment 7 Y.C. Chen 2005-11-06 21:56:42 UTC
Thanks!! We will use Bugzilla if we have any update. We think Someone senior help to review our code and then check into CVS will be better than we check into CVS directly. Otherwise, is it possible let our code into 7.0 release if 7.0 have patch later? Any comment is welcome!!
Comment 8 Adam Jackson 2005-11-07 17:21:16 UTC
(In reply to comment #7) > Otherwise, is it possible let our code into 7.0 release if 7.0 have patch > later? Starting with the 7.0 release, all drivers are split out into individual components and obey their own release schedules. Distributions shipping 7.0 can pick up the ast driver at any time. For 7.1 we'll be defining a list of components that will comprise the release. It is expected that almost all drivers hosted in Xorg CVS will be on this list, including this driver.
Comment 9 Y.C. Chen 2005-12-08 19:11:02 UTC
Created attachment 4044 [details] Modify H/W cursor parts for customer request Please reference ast_cursor.h, ast_cursor.c
Comment 10 Y.C. Chen 2006-01-05 20:05:05 UTC
Created attachment 4245 [details] Modify for xorg 6.9.0 support Can't reference XAACOPYROP in 6.9
Comment 11 Y.C. Chen 2006-02-06 15:58:17 UTC
Created attachment 4563 [details] Fixed get video buffer size incorrect issue
Comment 12 Y.C. Chen 2006-03-14 20:34:07 UTC
Created attachment 4932 [details] Fixed MMIO mode issue Display abnormal if set 2D Acceleration Option as MMIO mode
Comment 13 Alan Coopersmith 2006-03-15 10:09:13 UTC
I'll check this into modular CVS as a new driver/xf86-video-ast module. Question to Mr. Chen: once this is in our tree, will you be the maintainer for this driver? What should we list as the entry in the maintainers list? (See http://cvsweb.freedesktop.org/xorg/doc/xorg-docs/MAINTAINERS?view=markup for the current maintainers list and format of entries.)
Comment 14 Alan Coopersmith 2006-03-15 11:55:51 UTC
This is now committed to the Xorg modular tree, up to the version 0.80 in the latest attachment #4932 [details]. Additionally, some trivial changes to the include statements in the source code were made to allow building in the new 7.0 modular build system (the code provided included an Imakefile for the Xorg 6.9 and earlier build system): CVSROOT: /cvs/xorg Module name: driver Changes by: firstname.lastname@example.org 06/03/15 00:43:19 Log message: 2006-03-14 Alan Coopersmith <email@example.com> * COPYING: * autogen.sh: * configure.ac: * Makefile.am: * src/Makefile.am: * .cvsignore: * src/.cvsignore: Add the normal trappings of the Xorg modular build system. * src/ast_2dtool.c: * src/ast_accel.c: * src/ast_cursor.c: * src/ast_driver.c: * src/ast_mode.c: * src/ast_tool.c: * src/ast_vgatool.c: Replace "Xv.h" with <X11/extensions/Xv.h> and add #include "config.h" for modular build Strip ^M out of ast_accel.c Modified files: driver/xf86-video-ast/: ChangeLog driver/xf86-video-ast/src/: ast_2dtool.c ast_accel.c ast_cursor.c ast_driver.c ast_mode.c ast_tool.c ast_vgatool.c Added files: driver/xf86-video-ast/: .cvsignore COPYING Makefile.am autogen.sh configure.ac driver/xf86-video-ast/src/: .cvsignore Makefile.am Revision Changes Path 1.6 +23 -1 driver/xf86-video-ast/ChangeLog http://cvs.freedesktop.org/xorg/driver/xf86-video-ast/ChangeLog 1.3 +4 -1 driver/xf86-video-ast/src/ast_2dtool.c http://cvs.freedesktop.org/xorg/driver/xf86-video-ast/src/ast_2dtool.c 1.4 +1390 -1387driver/xf86-video-ast/src/ast_accel.c http://cvs.freedesktop.org/xorg/driver/xf86-video-ast/src/ast_accel.c 1.3 +4 -1 driver/xf86-video-ast/src/ast_cursor.c http://cvs.freedesktop.org/xorg/driver/xf86-video-ast/src/ast_cursor.c 1.5 +4 -1 driver/xf86-video-ast/src/ast_driver.c http://cvs.freedesktop.org/xorg/driver/xf86-video-ast/src/ast_driver.c 1.2 +4 -1 driver/xf86-video-ast/src/ast_mode.c http://cvs.freedesktop.org/xorg/driver/xf86-video-ast/src/ast_mode.c 1.2 +4 -1 driver/xf86-video-ast/src/ast_tool.c http://cvs.freedesktop.org/xorg/driver/xf86-video-ast/src/ast_tool.c 1.4 +4 -1 driver/xf86-video-ast/src/ast_vgatool.c http://cvs.freedesktop.org/xorg/driver/xf86-video-ast/src/ast_vgatool.c Reassigning back to general queue for handling inclusion in the Xorg 7.1 and possibly 6.9.1 releases.
Comment 15 Alan Coopersmith 2006-03-15 12:44:08 UTC
One other thing noticed in testing here - the current AST_NAME define in ast.h of "AST1000/2000" causes misformatted log messages: (II) AST1000/2000(0Creating default Display ... One easy fix is to change AST_NAME to a shorter string like "AST" so the messages look like: (II) AST(0): Creating default Display ... (The other would be to increase PREFIX_SIZE in hw/xfree86/common/xf86Helper.c to something larger than 14.)
Comment 16 Y.C. Chen 2006-03-15 20:36:08 UTC
Created attachment 4948 [details] Fixed Line Draw Incorrect Issue Dear Alan, Thanks for your kindly support. We are glad to maintain the AST code and I will apply to a account later. Otherwise, could you help to check the update into CVS this time? I will start from next time. Y.C. Chen
Comment 17 Daniel Stone 2006-03-15 20:57:59 UTC
hi y.c. chen, when you do decide to apply for an account, please follow the procedure on http://www.freedesktop.org/wiki/AccountRequests. don't worry about assigning to xorg first, just assign directly to product freedesktop.org, component New Accounts. thanks.
Comment 18 Alan Coopersmith 2006-03-16 08:09:48 UTC
Sure thing - I've checked the new update into Xorg modular CVS and see this fixed the driver name issue mentioned in the earlier comment as well. I've also added this to the Xorg maintainers file for now - please let me know if it's wrong (or correct it yourself once you get CVS access): xf86-video-ast P: Y.C. Chen M: firstname.lastname@example.org L: email@example.com W: http://wiki.x.org S: Maintained
Comment 19 Adam Jackson 2006-04-04 08:18:23 UTC
removing from 7.1 tracker, is already slated for inclusion.
Comment 20 Mike A. Harris 2006-08-31 07:27:27 UTC
AST driver already included now, closing as FIXED