Bug 49370

Summary: [next] rethink TpContact creation
Product: Telepathy Reporter: Xavier Claessens <xclaesse>
Component: tp-glibAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED DUPLICATE QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 31668    

Description Xavier Claessens 2012-05-02 02:52:11 UTC
Atm, to get a TpContact we have those functions:

 - I think CONTACT TpHandle must totally disappear from our API, and this function should be killed. I think in general high-level APIs should expose TpContact objects. At least spec should always give handle+id and so the recommended way to get a TpContact is tp_client_factory_ensure_contact() + eventually upgrade. Note that 'next' already make immortal handles mandatory.

 - It should be proper _async().
 - Should use GetContactAttributesByID (bug #30874) for massive simplification and single round-trip.

 - It should be proper _async().

 - Since we are making immortal handles mandatory, it is always possible to dup a contact with handle+id. In that case just use tp_client_factory_ensure_contact()
 - As said above, if you don't have id+handle, you should just never get a TpContact.
 - IIRC there are legitimate uses internally, when the spec gives only an handle but we are supposed to already have the TpContact (like removed members in group). So I suggest keeping some form of this but internal only.

One thing I would like is to ensure that at any moment, even internally, a TpContact has both id+handle. Making those 2 construct-only mandatory properties.
Comment 1 Xavier Claessens 2012-05-02 04:33:15 UTC

*** This bug has been marked as a duplicate of bug 27687 ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.