| Summary: | [softpipe] piglit vs-attrib-ivec4-implied regression | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Vinson Lee <vlee> |
| Component: | Other | Assignee: | mesa-dev |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | nobled |
| Version: | git | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
vs-attrib-ivec4-precision, vs-attrib-uvec4-implied, and vs-attrib-uvec4-precision have also regressed on softpipe. (In reply to comment #0) > Run piglit vs-attrib-ivec4-implied on softpipe. > > $ ./bin/shader_runner > tests/spec/glsl-1.30/execution/vs-attrib-ivec4-implied.shader_test -auto > Mesa warning: failed to remap index 173 > Test uses glVertexAttribIPointer(), which is unsupported. If I had to guess, with the bisected change the driver is no longer advertising OpenGL 3.0. The test only lists a requirement for GLSL 1.30, but it (implicitly) uses an API function from OpenGL 3.0. There are a couple possible ways to fix this, and Paul, Chad, and I have discussed a couple of them in the past. 1. Modify every shader_runner test that implicitly uses a OpenGL 2.1 or 3.0 function to also list a GL version requirement. This seems like a lot of work to fix the existing tests, and it seems like people will forget to do this on future tests. 2. Modify shader_runner to generate a skip result instead of failing in these cases. There were some arguments against this option, but I don't recall what they were. In any case, if you can verify that my hypothesis about the failure's root cause is correct, we should change this to be a piglit bug instead of a Mesa bug. > PIGLIT: {'result': 'fail' } > > > 8e90913e9f99ff3296a3c3da36e73cd2d4730269 is the first bad commit > commit 8e90913e9f99ff3296a3c3da36e73cd2d4730269 > Author: Dylan Noblesmith <nobled@dreamwidth.org> > Date: Sat Apr 21 19:35:48 2012 +0000 > > mesa: require GL_MAX_SAMPLES >= 4 for GL 3.0 > > As noted in commit be4e46b21a60cfdc826bf89d1078df54966115b1, > this was missing before. > > NOTE: This is a candidate for the 8.0 branch. > > Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> > > :040000 040000 86971ff2f0e2c6f16dde5519f70063a2f7465720 > 01c2357b726a870014ac77b1aaf611eeeb289b6b M src > bisect run success mesa: 83bba8f14603022c6c80bef95020e079d7cb73c0 (master 10.3.0-devel) vs-attrib-ivec4-implied passes on softpipe now. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Run piglit vs-attrib-ivec4-implied on softpipe. $ ./bin/shader_runner tests/spec/glsl-1.30/execution/vs-attrib-ivec4-implied.shader_test -auto Mesa warning: failed to remap index 173 Test uses glVertexAttribIPointer(), which is unsupported. PIGLIT: {'result': 'fail' } 8e90913e9f99ff3296a3c3da36e73cd2d4730269 is the first bad commit commit 8e90913e9f99ff3296a3c3da36e73cd2d4730269 Author: Dylan Noblesmith <nobled@dreamwidth.org> Date: Sat Apr 21 19:35:48 2012 +0000 mesa: require GL_MAX_SAMPLES >= 4 for GL 3.0 As noted in commit be4e46b21a60cfdc826bf89d1078df54966115b1, this was missing before. NOTE: This is a candidate for the 8.0 branch. Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> :040000 040000 86971ff2f0e2c6f16dde5519f70063a2f7465720 01c2357b726a870014ac77b1aaf611eeeb289b6b M src bisect run success