Bug 49588

Summary:	libva's source license headers conformance
Product:	libva	Reporter:	Ami Fischman <fischman>
Component:	core	Assignee:	haihao <haihao.xiang>
Status:	RESOLVED WORKSFORME	QA Contact:
Severity:	normal
Priority:	medium	CC:	gb.devel
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Ami Fischman 2012-05-07 08:41:52 UTC

Work is afoot to add libva support to Chromium to get HW video decode (http://crbug.com/117062).
While adding the libva headers to our repository we noticed a bunch of the files in the libva git repo don't have conforming license headers.  
Assuming this is an oversight would you consider making these files conformant?  Or would you accept a patch to do so?  (copying the header from a conforming file to all the rest?)

These are the non-conforming files detected by the checklicenses tool:
libva/autogen.sh
libva/build/gen_version.sh
libva/test/android_winsys.cpp
libva/test/egl/va_egl_x11.c
libva/test/encode/avcenc.c
libva/va/egl/va_egl_impl.c
libva/va/egl/va_egl_impl.h
libva/va/egl/va_egl_private.h
libva/va/va_android.h
libva/va/va_dummy.h
libva/va/va_egl.h
libva/va/va_x11.h
libva/va/x11/dri2_util.c
libva/va/x11/va_dri2.c
libva/va/x11/va_dri2.h
libva/va/x11/va_dri2str.h
libva/va/x11/va_dri2tokens.h
libva/va/x11/va_dricommon.c
libva/va/x11/va_dricommon.h

Comment 1 Gwenole Beauchesne 2012-06-28 13:40:22 UTC

Hi, Austin had fixed the files in the staging branch. I have propagated the change to master. Could you please re-run your license-check too? Thanks. Note that e.g. va_dri2.h looks like a valid license per the terms mentioned there. Do you have any concerns with it?

Comment 2 Ami Fischman 2012-06-28 14:11:52 UTC

As of ToT (8e8e58c292f979d869f101dd45cdb51752efa447) check_licenses complains about fewer files, but still finds some to complain about.  Of these, these files have no license header at all:

test/egl/va_egl_x11.c
va/va_egl.h
va/egl/va_egl_impl.h
va/egl/va_egl_private.h
va/egl/va_egl_impl.c

and these files have a license header that is not recognized by the tool:
libva/va/x11/va_dri2tokens.h
libva/va/x11/va_dri2str.h
libva/va/x11/va_dri2.h
libva/va/x11/va_dri2.c
by default, but these all look like BSD licenses so I think the tool should just be extended to handle this (the tool lives at http://src.chromium.org/viewvc/chrome/trunk/src/third_party/devscripts/licensecheck.pl?view=markup)

Gwenole: can you take care of the first set of files above?

Comment 3 haihao 2012-06-28 22:14:25 UTC

I added the license header to these files, could you try again ?

Comment 4 Ami Fischman 2012-06-29 08:00:39 UTC

Yep, all good now; thanks!

Comment 5 Chih-Chung Chang 2013-11-21 06:04:01 UTC

Hi,

I am trying to upgrade the libva headers in Chromium to release 1.2.1, 
The following two files don't have the standard license header:

va/egl/va_egl.h (no license header)
va/wayland/wayland-drm-client-protocol.h (non-standard license header)

Could you help fix them?

Thanks,
Chih-Chung Chang

(I am also happy to open another bug instead of reopening this one if that's better.)

Comment 6 haihao 2013-11-21 08:42:25 UTC

The license header used in wayland-drm-client-protocol.h is the old style of MIT license, does it confuse you ?

Comment 7 haihao 2015-11-18 08:14:38 UTC

No response from user for a long time so closing as WORKSFORME, Feel free to reopen this bug if you still experience the issue

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.