Bug 49842

Summary:	Unhandled rootfs on bind mount
Product:	udisks	Reporter:	Daniel Drake <dan>
Component:	general	Assignee:	David Zeuthen (not reading bugmail) <zeuthen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	gvfs-mount -li udisksctl dump /proc/self/mountinfo new dump

Description Daniel Drake 2012-05-12 09:17:55 UTC

Created attachment 61504 [details]
gvfs-mount -li

OLPC run / on a bind-mount for reasons described in http://lists.freedesktop.org/archives/devkit-devel/2012-May/001267.html

udisks_mount_monitor_get_mountinfo() seems to ignore such mounts:

      /* ignore mounts where only a subtree of a filesystem is mounted */
      if (g_strcmp0 (encoded_root, "/") != 0)
        continue;

This means that when we boot, we get the partition containing the root fs mounted as a user partition at /run/media/users/olpc/OLPCRoot. As its confusing for users we'd like to get rid of this.

Can udisks be made to understand this fs layout a little better?

Comment 1 Daniel Drake 2012-05-12 09:19:27 UTC

Created attachment 61505 [details]
udisksctl dump

Comment 2 Daniel Drake 2012-05-12 09:19:58 UTC

Created attachment 61506 [details]
/proc/self/mountinfo

Comment 3 Daniel Drake 2012-05-12 09:23:45 UTC

Version info:

Fedora 17 running on OLPC XO-1.75 (same problem seen on XO-1.5).

libatasmart-0.18-2.fc17.armv7hl
udisks2-1.94.0-1.fc17.armv7hl
gvfs-1.12.2-1.fc17.armv7hl

Comment 4 David Zeuthen (not reading bugmail) 2012-05-12 15:15:52 UTC

First of all, I'm guessing the mount /run/media/olpc/OLPCRoot is done by some gvfs-using automounter exactly because MountsPoints is empty, right? (ie. if we fix the bug this shouldn't happen)

I wonder what we _should_ be showing in MountPoints... there are two possibilities, ["/", "/home", "/versions"] or just ["/"] ... seems the former is more correct (for some values of correct) but the latter is fine too ... I think the latter (just "/") can be achieved by just removing the lines you quoted, e.g.

      /* ignore mounts where only a subtree of a filesystem is mounted */
      if (g_strcmp0 (encoded_root, "/") != 0)
        continue;

Any chance you can try this?

Comment 5 Daniel Drake 2012-05-14 14:16:27 UTC

Created attachment 61654 [details]
new dump

Yes, OLPCRoot is auto-mounted by Nautilus in the above dumps.

I removed the lines suggested and it solves the problem. The device appears with mountpoints which look reasonable, and Nautilus doesn't automount it in a strange place.

Comment 6 David Zeuthen (not reading bugmail) 2012-05-15 07:24:28 UTC

OK, I've removed those two lines - thanks for the bug report and testing!

http://cgit.freedesktop.org/udisks/commit/?id=e0b8ffe3099735fefd64973e6575c67ac0759be2

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.