Bug 49935

Summary: [PATCH] always check for valid shell
Product: accountsservice Reporter: Matthew Monaco <dgbaley27>
Component: generalAssignee: Matthias Clasen <mclasen>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium CC: rstrode
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: 0001-Add-user_local_get_shell.patch
0002-Check-shell-when-building-cached-list.patch

Description Matthew Monaco 2012-05-14 18:24:29 UTC
We're seeing the LightDM user show up in the user list of the greeter a lot. This patch fixes it.
Comment 1 Matthew Monaco 2012-05-14 18:25:21 UTC
Created attachment 61663 [details] [review]
0001-Add-user_local_get_shell.patch
Comment 2 Matthew Monaco 2012-05-14 18:25:54 UTC
Created attachment 61664 [details] [review]
0002-Check-shell-when-building-cached-list.patch
Comment 3 Ray Strode [halfline] 2012-05-14 19:32:32 UTC
are you seeing this with current master? We commited something similar recently, iirc
Comment 4 Matthew Monaco 2012-05-14 19:47:21 UTC
Yeah Ray. I sent that patch to the freedesktop mailing list on the 7th because I couldn't find a ML for accountsservice. Then on the 8th Christian Hesse must have sent you my patch and you committed it.
Comment 5 Ray Strode [halfline] 2012-05-14 20:39:50 UTC
ah, sorry the commit got misattributed.
Comment 6 Ray Strode [halfline] 2012-05-14 20:41:18 UTC
Also, thanks for writing the patch in the first place.  If you can confirm everything is working fine in master, then I'll close this bug out.
Comment 7 Matthew Monaco 2012-05-15 14:07:53 UTC
I can tell you that the patch I originally sent has been working for me for about a week now. If it breaks after the next release I'll reopen.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.