Bug 50021

Summary: src/gallium/drivers/r300/r300_state.c:716:17: error: incompatible type for argument 2 of ‘r300->rws->buffer_set_tiling’
Product: Mesa Reporter: Vinson Lee <vlee>
Component: Drivers/Gallium/r300Assignee: Default DRI bug account <dri-devel>
Status: RESOLVED FIXED QA Contact:
Severity: blocker    
Priority: medium CC: Enrico_m, michel
Version: unspecified   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Vinson Lee 2012-05-16 11:49:06 UTC 
mesa: 03e3bc4ba56f1021899a5f773b6ec21893619e3a (master)

$ scons
[...]
  Compiling src/gallium/drivers/r300/r300_state.c ...
src/gallium/drivers/r300/r300_state.c: In function ‘r300_tex_set_tiling_flags’:
src/gallium/drivers/r300/r300_state.c:716:17: error: incompatible type for argument 2 of ‘r300->rws->buffer_set_tiling’
src/gallium/drivers/r300/r300_state.c:716:17: note: expected ‘enum radeon_bo_layout’ but argument is of type ‘struct radeon_winsys_cs *’
src/gallium/drivers/r300/r300_state.c:716:17: error: too few arguments to function ‘r300->rws->buffer_set_tiling’
scons: *** [build/linux-x86_64-debug/gallium/drivers/r300/r300_state.os] Error 1
scons: building terminated because of errors.


11f056a3f0b87e86267efa8b5ac9d36a343c9dc1 is the first bad commit
commit 11f056a3f0b87e86267efa8b5ac9d36a343c9dc1
Author: Michel Dänzer <michel.daenzer@amd.com>
Date:   Wed May 16 17:45:17 2012 +0200

    r600g: Set tiling information for BOs being shared.
    
    Fixes https://bugs.freedesktop.org/show_bug.cgi?id=48747

:040000 040000 50daa6d7aceccb5f0697d46b9aa0ab03a13eae43 2b7c8f9c7f46546a6cf1159c741937160010d0d4 Msrc
Comment 1 Michel Dänzer 2012-05-16 15:15:48 UTC 
Commit: 7446a0407d4e61a826385c11ed6c401837baf095
Author: Michel Dänzer <michel.daenzer@amd.com>
Date:   Wed May 16 23:52:19 2012 +0200

gallium/radeon: Fix r300g tiling breakage.

Commit 11f056a3f0b87e86267efa8b5ac9d36a343c9dc1 broke the r300g build. Fix it
up, and reinstate some code which isn't needed by r600g and radeonsi but is
by r300g.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.