Bug 50261

Summary: [Regression] weston-terminal can't be inputted
Product: Wayland Reporter: ZhaoShengyan <shengyanx.zhao>
Component: westonAssignee: Wayland bug list <wayland-bugs>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: high CC: darxus
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description ZhaoShengyan 2012-05-23 00:18:32 UTC
System Environment:
--------------------------
Arch: 	i386
Libdrm: 	(master) 2.4.33-20-gd72a44c7c4f5eea9c1e5bb0c36cb9e0224b9ca22
Wayland: (master)35a92ef83ba24a0cced3c7c6b9fcde377a88f83b
Mesa: 	(master)c286278481b5d495223264332416d9e44eb625e7
Xserver: (master)xorg-server-1.12.0-172-gba883a0f3435d5da82a8134e696c4905eea70f23
Xf86_video_intel: (master)2.19.0-67-g952e3dcba3a651d22d44dbb039ad97e111d9bc63
Cairo: (master)aed94a5bc650f579368b4b814a8729570c32147e
Cairo_gl: (master)aed94a5bc650f579368b4b814a8729570c32147e
Xkbcommon: (master)8ca8f05aab86423c2495cd917489becfecca4632
Weston: 	(master)380deee3c7b18574d66511287bb01dde51027fbf
Kernel_unstable: (drm-intel-next-queued)78d56d78c3ab5eeca35c6fcb10301418eda8c405

Bug detailed description:
-----------------------------
Run case weston-terminal, click weston-terminal, type any button. Nothing is reacted. 
The issue can be reproduced both under drm and X mode.

Reproduce steps:
----------------------------
1. start weston under drm mode
2. ./weston-terminal
3. click terminal and input
Comment 1 ZhaoShengyan 2012-05-23 01:49:41 UTC
37816df64641a9b8bb922e938f902adc2374de2e is first bad commit.

commit 37816df64641a9b8bb922e938f902adc2374de2e
Author: Daniel Stone <daniel@fooishbar.org>
commit 37816df64641a9b8bb922e938f902adc2374de2e
Author: Daniel Stone <daniel@fooishbar.org>
Date:   Wed May 16 18:45:18 2012 +0100
 
    Convert wl_input_device to wl_seat (and friends)
    
    wl_input_device has been both renamed and split.  wl_seat is now a
    virtual object representing a group of logically related input devices
    with related focus.
    
    It now only generates one event: to let clients know that it has new
    capabilities.  It takes requests which hand back objects for the
    wl_pointer, wl_keyboard and wl_touch interfaces it exposes which all
    provide the old input interface, just under different names.
    
    This commit tracks these changes in weston and the clients, as well as
    similar renames (e.g. weston_input_device -> weston_seat).  Some other
    changes were necessary, e.g. renaming the name for the visible mouse
    sprite from 'pointer' to 'cursor' so as to not conflict.
    
    For simplicity, every seat is always exposed with all three interfaces,
    although this will change as time goes on.
    
    Signed-off-by: Daniel Stone <daniel@fooishbar.org>
Comment 2 Kristian Høgsberg 2012-05-23 07:29:16 UTC
I don't recognize the xkbcommon version here.  There have been protocol changes recently that could break things like this, but usually we coordinate breaks like that so that master of all repos always work.  I can't reproduce this problem, can you try again with master of at least wayland, weston and libxkbcommon?
Comment 3 Darxus 2012-05-23 08:01:02 UTC
> Xkbcommon: (master)8ca8f05aab86423c2495cd917489becfecca4632

That is the last commit in libxkbcommon master:  http://cgit.freedesktop.org/xorg/lib/libxkbcommon/log/

> 37816df64641a9b8bb922e938f902adc2374de2e is first bad commit.

That's in weston, and is 51 commits old.
Comment 4 ZhaoShengyan 2012-05-24 20:33:43 UTC
The issue can be reproduced at the lastest version:
System Environment:
--------------------------
Arch:       i386
Libdrm:     (master) 2.4.34-2-g481234f2909c0506962a2f42da862da6a9b13fd8
Wayland:    (master)5030af7635fc24b325a22d823ab0f51a4b099762
Mesa:       (master)c91b4edff978ee19afb4fe38ad69efc52db90691
Xserver:   
(master)xorg-server-1.12.0-189-g9bc53d8cb04af2be3feeebb1b10774c2d599a76b
Xf86_video_intel: (master)2.19.0-76-g54fde5bf05d43f26e7f1893584af736a138d245f
Cairo:      (master)dbc0efad7e565558a3abf7f69d7675efddc4688d
Cairo_gl:   (master)aed94a5bc650f579368b4b814a8729570c32147e
Xkbcommon:  (master)8ca8f05aab86423c2495cd917489becfecca4632
Weston:     (master)e68fd10f87deb99bb3a9a16b0734f9c6d1a6e529
Kernel_unstable:(drm-intel-next-queued)c8d4bb54c11c66610aaf8829acff6aa0506c7c29
Comment 5 Darxus 2012-05-24 20:52:40 UTC
I'm not seeing this problem.  I'm running weston-terminal from the icon on the launcher.  I have weston set suid root.

465319ce828f922edce46b6e7628da543b20d5e4 cairo/
652fe8d9dd2393127b11741ba63cb95a83ad454f dri2proto/
481234f2909c0506962a2f42da862da6a9b13fd8 drm/
29d5b553b30755a25300c30b67d39b37c9a76466 glproto/
e752e92dbdcf01b1cd46a3853f582ff765d19e90 inputproto/
391a1f6de6315fc0196d407d800597488315cccb kbproto/
9f2d95e61896f41adb8087fb805eb37899cce55f libpciaccess/
0bbc0d5e605e2a4a3eb00a229b651d4546e8aef4 libX11/
8ca8f05aab86423c2495cd917489becfecca4632 libxkbcommon/
0890e4003aacfa7113ab3f4e3ad7c5636f8e922a macros/
35f302d97e5b6f5fc4964e70f7adae706c5b7162 mesa/
30816e3068bccf7c78c78f916b54971d24873bdc pixman/
f10d1a91ea2e98a3c402b8bc2cb5d9b52c667db4 wayland/
5fb70bf301ec2ff6a05cff1d880cb9640f599929 weston/
a6651a8d812d224a9e74205bdefb7081f743af11 xproto/

The weston commit I used is newer than the one you used.
Comment 6 Kristian Høgsberg 2012-05-25 07:03:25 UTC
(In reply to comment #4)
> The issue can be reproduced at the lastest version:

Yes, I've seen it myself a few times now.  It's a stuck modifier problem and I think we should be able to fix it today.

> System Environment:
> --------------------------
> Arch:       i386
> Libdrm:     (master) 2.4.34-2-g481234f2909c0506962a2f42da862da6a9b13fd8
> Wayland:    (master)5030af7635fc24b325a22d823ab0f51a4b099762
> Mesa:       (master)c91b4edff978ee19afb4fe38ad69efc52db90691
> Xserver:   
> (master)xorg-server-1.12.0-189-g9bc53d8cb04af2be3feeebb1b10774c2d599a76b
> Xf86_video_intel: (master)2.19.0-76-g54fde5bf05d43f26e7f1893584af736a138d245f
> Cairo:      (master)dbc0efad7e565558a3abf7f69d7675efddc4688d
> Cairo_gl:   (master)aed94a5bc650f579368b4b814a8729570c32147e
> Xkbcommon:  (master)8ca8f05aab86423c2495cd917489becfecca4632
> Weston:     (master)e68fd10f87deb99bb3a9a16b0734f9c6d1a6e529
> Kernel_unstable:(drm-intel-next-queued)c8d4bb54c11c66610aaf8829acff6aa0506c7c29
Comment 7 ZhaoShengyan 2012-06-05 20:20:41 UTC
This bug has been fixed at:
Arch:               i386
Libdrm:             (master) 2.4.34-2-g481234f2909c0506962a2f42da862da6a9b13fd8
Wayland:            (master) 3fd1e128e95770526d2c247aef9544a6abdb7848
Mesa:               (master) 555e00fdc30514b45e9afae18f56a9a4bc65f364
Xserver:            (master)
xorg-server-1.12.0-197-g3476eb38063473a7a5fcd78e2095e284118de839
Xf86_video_intel:   (master)
2.19.0-205-g81f09347f2ab59cf0a3eaca7be83ded555655e93
Cairo:              (master) dbc0efad7e565558a3abf7f69d7675efddc4688d
Cairo_gl:           (master) 9fa047c0ea49d94f9f27947931fe21b70f6463d5
Xkbcommon:          (master) 734be50050601987da680597f5dafc41c6421fbb
Weston:             (master) 6597506ac3926f57bc29bf41219e947a5a826434
Kernel_unstable:   
(drm-intel-next-queued)1523c310b3ed964b71a8db16f70c3bc21cc0642e

Mark the bug as RESOLVED and FIXED.
Comment 8 ZhaoShengyan 2012-06-05 20:21:10 UTC
Mark the bug as VERIFIED and FIXED.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.