Bug 50416

Summary:	[patch] add explaination to enum _cairo_int_status
Product:	cairo	Reporter:	Homer Hsing <dongsheng.xing>
Component:	general	Assignee:	Bryce Harrington <bryce>
Status:	RESOLVED FIXED	QA Contact:	cairo-bugs mailing list <cairo-bugs>
Severity:	normal
Priority:	medium
Version:	1.12.2
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Homer Hsing 2012-05-28 01:25:27 UTC

In the source code, the "int" in "_cairo_int_status" means "internal". But the code readers maybe do not interpret "int" as "internal". The patch clarifies the meaning.

diff --git a/src/cairo-error-private.h b/src/cairo-error-private.h
index ea9c2ea..798b82b 100644
--- a/src/cairo-error-private.h
+++ b/src/cairo-error-private.h
@@ -46,7 +46,8 @@
 
 CAIRO_BEGIN_DECLS
 
-/* Sure wish C had a real enum type so that this would be distinct
+/* _cairo_int_status: internal status
+ *
+ * Sure wish C had a real enum type so that this would be distinct
  * from #cairo_status_t. Oh well, without that, I'll use this bogus 100
  * offset.  We want to keep it fit in int8_t as the compiler may choose
  * that for #cairo_status_t */

Comment 1 Bryce Harrington 2014-02-27 02:41:30 UTC

commit be206ddf20e7b4e0e87d91c7a18cbdb9cfcec8e6
Author: Bryce Harrington <b.harrington@samsung.com>
Date:   Wed Feb 26 18:40:12 2014 -0800

    Add explanation to enum _cairo_int_status

    Patch based on suggestion by Homer Hsing

    Bugzilla:  https://bugs.freedesktop.org/show_bug.cgi?id=50416

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.