Bug 50630

The packimages.pl script is called from packimages/CustomTarget_images.mk line 41 <http://opengrok.libreoffice.org/xref/core/packimages/CustomTarget_images.mk#41>

It reads image list from $(OUTDIR)/res/img which contains lots of *.ilst files

The problematic files in $(OUTDIR)/res/img/:

* abpen-US.ilst: %MODULE%\res\addresspilot.png

* scnen-US.ilst: %MODULE%\scanner\handle.png, %MODULE%\scanner\plus.png, %MODULE%\scanner\minus.png

* updchken-US.ilst: %MODULE%\ui\onlineupdate_16.png, %MODULE%\ui\onlineupdate_26.png

These *ilst files come from "Resource Compiler" in $(OUTDIR)/bin/rsc.exe, which compiled from rsc/source/rsc/rsc.cxx

And *ilst files come in `make extensions`:
> [ build RES ] abpen-US    <<< problematic
> [ build RES ] biben-US
> [ build RES ] dbpen-US
> [ build RES ] pcren-US
> [ build RES ] scnen-US    <<< problematic
> [ build RES ] upden-US
> [ build RES ] updchken-US <<< problematic

which invoke the AllLangResTarget.mk line 326 <http://opengrok.libreoffice.org/xref/core/solenv/gbuild/AllLangResTarget.mk#326>

The point which create problem is the parameter -subMODULE (line 344) -- it is
> -subMODULE=$S/icon-themes/galaxy/extensions/

This will make aSearch in rsc.cxx line 1095 to be
> d:\libo\icon-themes\galaxy\extensions
and aSearchIn (line 1096) to be
> d:\libo\icon-themes\galaxy\extensions\res\addresspilot.png

The next code is to make a tailing string of aSearchIn from aSearch, ie you get rImagePath (line 1108, 1126) as
> res/addresspilot.png

and then it will be transformed to be
> %MODULE%\res\addresspilot.png
as in abpen-US.ilst

So, how this come?
> The point which create problem is the parameter -subMODULE (line 344) -- it is
> > -subMODULE=$S/icon-themes/galaxy/extensions/
> 
> This will make aSearch in rsc.cxx line 1095 to be
> > d:\libo\icon-themes\galaxy\extensions

it comes from rsc.cxx line 174-187, m_aReplacements will have a ::std::pair of
> "MODULE" => "d:\libo\icon-themes\galaxy\extensions"

then, line 1095 will get the second element of this pair into aSearch.


If I try replacing
> -subMODULE=$S/icon-themes/galaxy/extensions/
with
> -subMODULE=$S/icon-themes/galaxy/

in the command line invoking, this solves the problem.


Back to AllLangResTarget.mk line 344,
> -subMODULE=$(dir $(gb_ResTarget_DEFIMAGESLOCATION)$(RESLOCATION)) \

the $(RESLOCATION) is "extensions/"

I'm not sure if we can remove $(RESLOCATION) or not.


Comparing with another non-problematic files:
[ build RES ] biben-US use -subMODULE= (blank)
[ build RES ] pcren-US use -subMODULE=$S/icon-themes/galaxy/


Any idea how to fix this bug? Thanks!

The definition of -subMODULE in AllLangResTarget.mk was changed as fix for https://issues.apache.org/ooo/show_bug.cgi?id=116298 , but I do not even understand what that bug is supposed to be about... Anyway, I think it is wrong.

Thanks for the information.

Anyway, is this bug really FIXED?
If you apply this patch (generated on old master, sorry), you will see the warning for missing images.

diff --git a/solenv/bin/packimages.pl b/solenv/bin/packimages.pl
index 12eb3ea..1cd6a04 100755
--- a/solenv/bin/packimages.pl
+++ b/solenv/bin/packimages.pl
@@ -362,7 +362,7 @@ sub create_zip_archive
                 print_error("can't add file '$path' to image zip archive: $!", 5);
             }
         } else {
-                print_message("file '$path' not found");
+                print_warning("file '$path' not found");
         }
     }
     my $status = $zip->writeToFileNamed($tmp_out_file);

Created attachment 62492 [details]
screenshot showing localhelp file missing image

Also, testing with official Alpha 1 release, on Windows XP, will show you that the images are still missing.

Steps:
1. Install libo and local helppack
2. Help > LODev Help
3. Index > "updates;checking manually"
4. See the missing image as attached screenshot (compare with 3.5.3)

5. Searching in path-to-install/share/config/images*.zip/extensions/res/, the images listed in comment 0 are not found.

David Tardon committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=52cd118b4e460787059aeab90bdbe5bc9ef33cbd

fdo#50630 set correct path to images' module dir

Korrawit Pruegsanusak committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5d1ea0b2253d9d09aad96f0b6b0251d20d063856

related fdo#50630: use print_warning when image not found

> Anyway, is this bug really FIXED?
> If you apply this patch (generated on old master, sorry), you will see the
> warning for missing images.

RESOLVED/FIXED status in bugzilla does not necessarily mean the fix has been pushed to master already. You should have some patience.

> Created attachment 62492 [details]
> screenshot showing localhelp file missing image
> 
> Also, testing with official Alpha 1 release, on Windows XP, will show you that
> the images are still missing.

Alpha 1 was built several days ago. Sorry, but I am not able to apply a patch retroactively.

Sorry :-( and thanks for the fix.

VIRIFIED on Windows XP with build from tinderbox Win-x86@6-fast, pull
time 2012-06-05 23:16:58, core: b255de87082d11a42d7af7860dcc4e971342df0

Thanks again :)

We need exact and correct target information for automated lists in Wiki and LibO Web Site.