Bug 50808

Summary: [E6510]eDP powered off while attempting aux channel communication while running testdisplay
Product: DRI Reporter: Guang Yang <guang.a.yang>
Component: DRM/IntelAssignee: Daniel Vetter <daniel>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: medium CC: ben, chris, daniel, jbarnes
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
running testdiplay debug info
none
enable edp vdd in intel_dp_detect
none
patch v2, first is slightly broken
none
running testdiplay with patch debug info
none
patch v3
none
running testdiplay with patch v3 debug info
none
running testdiplay with patch V3 debug info
none
dont probe OUI for eDP none

Description Guang Yang 2012-06-06 19:19:49 UTC
Created attachment 62687 [details]
running testdiplay debug info

System Environment:
--------------------------
Platform:        E6510
Kernel: (drm-intel-testing)ae6b908db592cf55dbebdb01e39e3b492993344c
Bug detailed description:
-------------------------
   On E6510 platform ,While running testdisplay -i with EDP only and doesn't connect and VGA monitor, it shows: 
Connectors:
id	encoder	status		type	size (mm)	modes
7	8	connected	Embedded DisplayPort	340x190		2
  modes:
  name refresh (Hz) hdisp hss hse htot vdisp vss vse vtot flags type clock
  1366x768 60 1366 1398 1422 1426 768 771 775 806 0x9 0x48 69000
  1366x768 40 1366 1398 1422 1426 768 771 775 806 0x9 0x40 46000
11	12	connected	VGA	0x0		5
  modes:
  name refresh (Hz) hdisp hss hse htot vdisp vss vse vtot flags type clock
  1024x768 60 1024 1048 1184 1344 768 771 777 806 0xa 0x40 65000
  800x600 60 800 840 968 1056 600 601 605 628 0x5 0x40 40000
  800x600 56 800 824 896 1024 600 601 603 625 0x5 0x40 36000
  848x480 60 848 864 976 1088 480 486 494 517 0x5 0x40 33750
  640x480 60 640 656 752 800 480 489 492 525 0xa 0x40 25175
14	0	disconnected	HDMI-A	0x0		0
15	0	disconnected	DisplayPort	0x0		0
18	0	disconnected	HDMI-A	0x0		0
20	0	disconnected	HDMI-A	0x0		0
21	0	disconnected	DisplayPort	0x0		0
23	0	disconnected	DisplayPort	0x0		0

CRTCs:
id	fb	pos	size
3	36	(0,0)	(0x0)
  1366x768 60 1366 1398 1422 1426 768 771 775 806 0x9 0x48 69000
5	36	(0,0)	(0x0)
  1024x768 60 1024 1048 1184 1344 768 771 777 806 0xa 0x40 65000

while running testdisplay -a,is shows:
CRTS(3):  1366x768 60 1366 1398 1422 1426 768 771 775 806 0x9 0x48 69000
CRTS(3):  1366x768 40 1366 1398 1422 1426 768 771 775 806 0x9 0x40 46000
CRTS(3):  1024x768 60 1024 1048 1184 1344 768 771 777 806 0xa 0x40 65000
CRTS(3):  800x600 60 800 840 968 1056 600 601 605 628 0x5 0x40 40000
CRTS(3):  800x600 56 800 824 896 1024 600 601 603 625 0x5 0x40 36000
CRTS(3):  848x480 60 848 864 976 1088 480 486 494 517 0x5 0x40 33750
CRTS(3):  640x480 60 640 656 752 800 480 489 492 525 0xa 0x40 25175


 In dmesg shows:

[  589.093453] WARNING: at drivers/gpu/drm/i915/intel_dp.c:353 intel_dp_check_edp+0x3f/0x7b [i915]()
[  589.093454] Hardware name: Latitude E6510
[  589.093454] eDP powered off while attempting aux channel communication.
[  589.093476] Modules linked in: lockd ipt_REJECT ip6t_REJECT nf_conntrack_ipv4 nf_defrag_ipv4 xt_tcpudp nf_conntrack_ipv6 iptable_filter nf_defrag_ipv6 ip_tables xt_state nf_conntrack ip6table_filter ip6_tables x_tables snd_hda_codec_hdmi snd_hda_codec_idt snd_hda_intel snd_hda_codec snd_hwdep snd_seq snd_seq_device snd_pcm coretemp hwmon snd_timer snd kvm_intel iTCO_wdt soundcore dcdbas i2c_i801 iTCO_vendor_support e1000e joydev kvm snd_page_alloc microcode pcspkr sg wmi ppdev parport_pc parport battery ac uinput sunrpc ipv6 autofs4 ext3 jbd mbcache sr_mod cdrom sd_mod firewire_ohci firewire_core crc_itu_t ehci_hcd i915 drm_kms_helper drm i2c_algo_bit button i2c_core video dm_mirror dm_region_hash dm_log dm_mod [last unloaded: scsi_wait_scan]
[  589.093478] Pid: 375, comm: kworker/0:1 Tainted: G        W    3.4.0_stable_20120606+ #1
[  589.093478] Call Trace:
[  589.093481]  [<c02230c2>] warn_slowpath_common+0x63/0x78
[  589.093496]  [<f8499ff3>] ? intel_dp_check_edp+0x3f/0x7b [i915]
[  589.093498]  [<c022313b>] warn_slowpath_fmt+0x26/0x2a
[  589.093515]  [<f8499ff3>] intel_dp_check_edp+0x3f/0x7b [i915]
[  589.093531]  [<f849a061>] intel_dp_aux_ch+0x32/0x27b [i915]
[  589.093547]  [<f849a025>] ? intel_dp_check_edp+0x71/0x7b [i915]
[  589.093564]  [<f849a3fc>] intel_dp_aux_native_read_retry+0x61/0xc3 [i915]
[  589.093581]  [<f849b9c9>] intel_dp_detect+0x13c/0x1cd [i915]
[  589.093585]  [<f81afbd1>] output_poll_execute+0x7a/0x12c [drm_kms_helper]
[  589.093587]  [<c04046f9>] ? tty_ldisc_deref+0x8/0xa
[  589.093589]  [<c0235fe6>] process_one_work+0x174/0x29f
[  589.093593]  [<f81afb57>] ? drm_helper_connector_dpms+0xb9/0xb9 [drm_kms_helper]
[  589.093595]  [<c0236391>] worker_thread+0x12f/0x1e5
[  589.093596]  [<c0236262>] ? rescuer_thread+0x130/0x130
[  589.093598]  [<c0239400>] kthread+0x67/0x6c
[  589.093600]  [<c0239399>] ? kthread_freezable_should_stop+0x49/0x49
[  589.093602]  [<c053ad56>] kernel_thread_helper+0x6/0xd

I tried this kernel,the issue still occurs.
Kernel: (drm-intel-fixes)cb05d8dedefa3066bf5d74ef88c6ca6cf4bd1c87
Comment 1 Daniel Vetter 2012-06-07 00:10:01 UTC
Created attachment 62692 [details] [review]
enable edp vdd in intel_dp_detect

Please try this patch, it should fix the issue.
Comment 2 Daniel Vetter 2012-06-07 00:23:15 UTC
Created attachment 62694 [details] [review]
patch v2, first is slightly broken

Please test with this one instead, thanks.
Comment 3 Guang Yang 2012-06-07 02:46:16 UTC
(In reply to comment #2)
> Created attachment 62694 [details] [review] [review]
> patch v2, first is slightly broken
> 
> Please test with this one instead, thanks.
I try this patch with the latest -fixes ,it doesn't work.
Comment 4 Daniel Vetter 2012-06-07 05:04:18 UTC
Hm, can you please attach full dmesg with the backtraces when running with drm.debug=0xe and my patch?
Comment 5 Guang Yang 2012-06-07 06:21:46 UTC
Created attachment 62716 [details]
running testdiplay with patch debug info

Here is the dmesg with patch and drm.debug=0xe
Comment 6 Daniel Vetter 2012-06-07 06:33:13 UTC
Created attachment 62717 [details] [review]
patch v3

Ok, with the dmesg I've noticed a few other places that are now wrong. Hopefully working patch attached, please test.
Comment 7 Guang Yang 2012-06-07 19:24:23 UTC
Created attachment 62775 [details]
running testdiplay with patch v3 debug info

(In reply to comment #6)
> Created attachment 62717 [details] [review] [review]
> patch v3
> 
> Ok, with the dmesg I've noticed a few other places that are now wrong.
> Hopefully working patch attached, please test.
OK, I try the newest patch, the issue still occurs, and I attach the dmesg.
Comment 8 Daniel Vetter 2012-06-07 23:14:56 UTC
Hm, I can't find the WARNING in the dmesg you've attached. But it's also cut off a bit at the beginning. Can you please dig out the part of dmesg where it still fails with this warning with patch v3?
Comment 9 Guang Yang 2012-06-10 19:16:55 UTC
Created attachment 62866 [details]
running testdiplay with patch V3 debug info

(In reply to comment #8)
> Hm, I can't find the WARNING in the dmesg you've attached. But it's also cut
> off a bit at the beginning. Can you please dig out the part of dmesg where it
> still fails with this warning with patch v3?
I try the latest -fixes branch with patch V3,the bug is gone, and I attach the dmesg.
 The commit is :
Kernel: (drm-intel-fixes)c5bf7e4ee1f4ff762d14934fb753a9c2b4e2d87f
Comment 10 Daniel Vetter 2012-06-11 12:22:33 UTC
Created attachment 62901 [details] [review]
dont probe OUI for eDP
Comment 11 Daniel Vetter 2012-06-11 12:23:11 UTC
Totally new patch, the old one died in review. Can you please test whether this one also works?
Comment 12 Guang Yang 2012-06-12 02:22:17 UTC
(In reply to comment #11)
> Totally new patch, the old one died in review. Can you please test whether this
> one also works?
Yes,this patch can work well,too.
Comment 13 Daniel Vetter 2012-06-20 01:08:57 UTC
Patch merged to -fixes as

commit 351cfc34db8decb0c5cc1aac7cf1780a0e45c8b1
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Tue Jun 12 13:20:47 2012 +0200

    drm/i915: eDP aux needs vdd
Comment 14 Elizabeth 2017-10-06 14:49:51 UTC
Closing old verified.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.