| Summary: | piglit fs-clip-distance-interpolated regression | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Vinson Lee <vlee> |
| Component: | Mesa core | Assignee: | mesa-dev |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | galibert |
| Version: | git | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
fs-clip-distance-interpolated.png
clipdistance interpolation type correction |
||
Created attachment 63377 [details]
fs-clip-distance-interpolated.png
Created attachment 63395 [details] [review] clipdistance interpolation type correction Interesting, thanks for the report. The fix bisect points to has unearthed an older bug were the code said the clip distances should be interpolated in screen space, which is wrong. Thanks again, OG. mesa: 1d21bd057a6b1701dd44a79e82259c0f3ded2b70 (master) piglit fs-clip-distance-interpolated is still failing on softpipe. Patch is awaiting review. http://lists.freedesktop.org/archives/mesa-dev/2012-June/023209.html OG. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
mesa: 78ac9af58021b7cc649c35fda112f61c98b31766 Run piglit fs-clip-distance-interpolated on softpipe. $ ./bin/shader_runner tests/spec/glsl-1.30/execution/clipping/fs-clip-distance-interpolated.shader_test -auto Mesa warning: failed to remap index 173 Probe at (0,0) Expected: 0.000000 1.000000 0.000000 1.000000 Observed: 0.000000 0.000000 0.000000 0.000000 PIGLIT: {'result': 'fail' } 4625a9b1adf7a30c56e2bbeb41573fbba4465851 is the first bad commit commit 4625a9b1adf7a30c56e2bbeb41573fbba4465851 Author: Olivier Galibert <galibert@pobox.com> Date: Tue Jun 19 20:51:19 2012 +0200 draw: fix flat shading and screen-space linear interpolation in clipper This includes: - picking up correctly which attributes are flatshaded and which are noperspective - copying the flatshaded attributes when needed, including the non-built-in ones - correctly interpolating the noperspective attributes in screen-space instead than in a 3d-correct fashion. Signed-off-by: Olivier Galibert <galibert@pobox.com> Reviewed-by: Brian Paul <brianp@vmware.com> :040000 040000 090014c9dd5d0b75d2fa87fe248496c142a4095c fb5b3d37d3854ca91661384af17bfebac8859a7f M src bisect run success