Bug 51628

Summary: Fix configure displaying no no
Product: cairo Reporter: Gilles Espinasse <g.esp>
Component: generalAssignee: Carl Worth <cworth>
Status: RESOLVED FIXED QA Contact: cairo-bugs mailing list <cairo-bugs>
Severity: normal    
Priority: medium    
Version: 1.12.2   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: git patch

Description Gilles Espinasse 2012-07-01 14:06:24 UTC
Created attachment 63680 [details]
git patch

Inside PKG_CHECK_MODULES, AC_MSG_RESULT(no) is already displayed, so the caller should not print 'no' again.

Remove AC_MSG_RESULT(no) on the caller side.

Add a comment for the special behavior triggered when ACTION-IF-NOT-FOUND is empty as that hit me, while removing AC_MSG_RESULT(no)
Comment 1 Gilles Espinasse 2012-10-09 07:37:01 UTC
ping
Comment 2 Chris Wilson 2012-10-21 08:38:11 UTC
commit b12a94b98306d87689bad23dad4c0ec033037046
Author: Gilles Espinasse <g.esp@free.fr>
Date:   Sat Oct 20 20:22:50 2012 +0200

    configure: fix PKG_CHECK_MODULES tests displaying no no
    
    Inside PKG_CHECK_MODULES, AC_MSG_RESULT(no) is already displayed, so the
    caller should not use another AC_MSG_RESULT(no).
    
    Add a comment that empty ACTION-IF-NOT-FOUND is not allowed for
    PKG_CHECK_MODULES, but a simple : is enough.
    
    This is bugs.freedesktop.org #51628, rediffed after 1.12.4
    
    Signed-off-by: Gilles Espinasse <g.esp@free.fr>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.