Bug 51642

Summary: [Bisect regression]Piglit fbo_fbo-blit fails
Product: Mesa Reporter: lu hua <huax.lu>
Component: Drivers/DRI/i915Assignee: Ian Romanick <idr>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: high CC: maraeo, xunx.fang
Version: git   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: nexuiz Screenshot
xonotic Screenshot

Description lu hua 2012-07-01 20:17:57 UTC
System Environment:
--------------------------
Arch:             x86_64
Platform:         Ivybridge
Libdrm:		(master)libdrm-2.4.37
Mesa:		(master)db2b6ca504e5046697e3d9262cfd401b8a4971fd
Xserver:(master)xorg-server-1.12.0-233-gdae317e7265007b38012244722e3b3a06e904ed5
Xf86_video_intel:(master)2.19.0-361-gabd7be1cee6f2f494a11cd9d2e7888c3043ffc02
Libva:		(staging)f12f80371fb534e6bbf248586b3c17c298a31f4e
Libva_intel_driver:(staging)82fa52510a37ab645daaa3bb7091ff5096a20d0b
Kernel:	(drm-intel-next-queued) 146937e5828ede495e11ba3a6f4a01b36b7166dc

Bug detailed description:
------------------------------
It fails on ivybridge, sandybridge,ironlake and pineview with mesa master branch.It doesn't happen on meda 8.0 branch.

Some "fbo_fbo-", "general_", "glx_glx-", "hiz_hiz-depth-", "hiz_hiz-stencil-", "shaders_", "spec_ARB_", "spec_ATI_", "spec_EXT_", "spec_NV_conditional_render_" and "texturing_"cases also fail with the same commit.

Following Oglc cases also fail with the same commit:
mustpass(basic.drawElements)
ver_colormat(advanced.vertexArray.drawArrays)
ver_colormat(advanced.vertexArray.drawElements)
ver_colormat(advanced.vertexArray.multiDrawArrays)
ver_colormat(advanced.vertexArray.vertexBufferObject)
pbo(vboAndFBO.pboDataAsVertexArray)

output:
Probe at (10,10)
  Expected: 1.000000 0.000000 0.000000
  Observed: 1.000000 1.000000 1.000000
Probe at (10,40)
  Expected: 1.000000 0.000000 0.000000
  Observed: 1.000000 1.000000 1.000000
Probe at (10,70)
  Expected: 1.000000 0.000000 0.000000
  Observed: 1.000000 1.000000 1.000000
Probe at (10,10)
  Expected: 1.000000 0.000000 0.000000
  Observed: 1.000000 1.000000 1.000000
Probe at (10,40)
  Expected: 1.000000 0.000000 0.000000
  Observed: 1.000000 1.000000 1.000000
PIGLIT: {'result': 'fail' }

Bisect shows: 62b971673950148eb949ba23d7fdc47debea16f0 is the first commit.
commit 62b971673950148eb949ba23d7fdc47debea16f0
Author:     Marek Olšák <maraeo@gmail.com>
AuthorDate: Wed Jun 27 06:10:30 2012 +0200
Commit:     Marek Olšák <maraeo@gmail.com>
CommitDate: Thu Jun 28 22:46:51 2012 +0200

    vbo: first ASSERT_OUTSIDE_BEGIN_END then FLUSH, not the other way around

    Reviewed-by: Brian Paul <brianp@vmware.com>

Reproduce steps:
----------------------------
1. start x
2. ./bin/fbo-blit -auto
Comment 1 lu hua 2012-07-01 22:15:58 UTC
Following Ogles1conform cases also fail, and have same bisect result.

xformn.c
bcolor.c
colramp.c
zbfunc.c
dither.c
logicop.c
l_am.c
l_ac.c
l_ap.c
l_dl.c
l_dm.c
l_dmn.c
l_dmp.c
l_em.c
l_se.c
l_sen.c
l_sl.c
l_sm.c
l_sn.c
l_sp.c
fogexp.c
foglin.c
packpix.c
rescalen.c
copytex.c
texcombine.c
Comment 2 ye.tian 2012-07-02 01:58:46 UTC
Created attachment 63691 [details]
nexuiz Screenshot
Comment 3 ye.tian 2012-07-02 01:59:32 UTC
Created attachment 63692 [details]
xonotic Screenshot
Comment 4 ye.tian 2012-07-02 02:05:01 UTC
The nexuiz and xonotic games display abnormally. 
Bisect shows: 62b971673950148eb949ba23d7fdc47debea16f0 is first bad commit.
Comment 5 Marek Olšák 2012-07-02 06:54:17 UTC
I am investigating this issue and trying to figure out wtf is going on and why gallium drivers don't have this issue while using exactly the same code.

I will revert the commit if I don't find a fix soon.
Comment 6 lu hua 2012-07-04 20:48:48 UTC
It fixed with commit 9f0f2f9512c3c9dcf875efa490b587f010b260c1.
Comment 7 lu hua 2012-07-04 20:49:39 UTC
Verified. Fixed with commit 9f0f2f9512c3c9dcf875efa490b587f010b260c1.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.