Bug 51956

Summary: EnumStrings.LookUpByNumber regression
Product: Mesa Reporter: Vinson Lee <vlee>
Component: Mesa coreAssignee: mesa-dev
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium CC: maraeo
Version: git   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Vinson Lee 2012-07-10 18:23:42 UTC 
mesa: 67a8ee891b2e119d826d8f830c1cbbe64ecb4f82 (master)

$ make check
[...]
[==========] Running 4 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 4 tests from EnumStrings
[ RUN      ] EnumStrings.LookUpByNumber
enum_strings.cpp:54: Failure
Value of: _mesa_lookup_enum_by_nr(everything[i].value)
  Actual: "GL_TIME_ELAPSED"
Expected: everything[i].name
Which is: "GL_TIME_ELAPSED_EXT"
[  FAILED  ] EnumStrings.LookUpByNumber (1 ms)



4952caad2dbf8668d86c3043b5761c61382bbb4c is the first bad commit
commit 4952caad2dbf8668d86c3043b5761c61382bbb4c
Author: Marek Olšák <maraeo@gmail.com>
Date:   Tue Jun 26 01:36:44 2012 +0200

    glapi: add ARB_timer_query

    Reviewed-by: Brian Paul <brianp@vmware.com>

:040000 040000 7e6016519ee95a7681a00bb7df928403f54bdbd2 e260426c8823c355cc6ca16eb789bed0beeeddaf M      src
bisect run success
Comment 1 Ian Romanick 2012-07-10 20:18:07 UTC 
Changing the name is fine.  The test just needs to have the new name replace the old name too.
Comment 2 Ian Romanick 2012-07-10 21:48:11 UTC 
commit 4fae5e32d5272986e9e64303eadc974d57e7b3ed
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Tue Jul 10 13:37:06 2012 -0700

    mesa/test: Update name of GL_TIME_ELAPSED
    
    4952caa caused the _EXT to fall off the name of this enum.  This is
    fine.  Update the unit test to expect the new value.
    
    Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=51956

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.