| Summary: | Gabble's Call1 RequestableChannelClasses are wrong | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | George Kiagiadakis <gkiagia> |
| Component: | gabble | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED MOVED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://cgit.collabora.com/git/user/wjt/telepathy-gabble/log/?h=51978-call-caps | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
Contact capabilities are apparently also wrong in the same way. Ping? Any thoughts on this one? I wrote the test case and then started fixing Gabble and then lost the will to live. -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-gabble/issues/233. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
According to the spec: " The RequestableChannelClasses for Call1 channels can be: [( Fixed = { ...ChannelType: ...Call1, ...TargetHandleType: Contact, ...InitialVideo: True }, Allowed = [ ...InitialVideoName, ...InitialAudio, ...InitialAudioName ] ), ( Fixed = { ...ChannelType: ...Call1, ...TargetHandleType: Contact, ...InitialAudio: True }, Allowed = [ ...InitialAudioName, ...InitialVideo, ...InitialVideoName ] )] Clients aren't allowed to make outgoing calls that have neither initial audio nor initial video. Clearly, CMs which don't support video should leave out the first class and omit InitialVideo from the second class, and vice versa for CMs without audio support. " Apparently gabble advertises just: [call1-1on1-5] org.freedesktop.Telepathy.Channel.TargetHandleType u=1 org.freedesktop.Telepathy.Channel.ChannelType s=org.freedesktop.Telepathy.Channel.Type.Call1 allowed=org.freedesktop.Telepathy.Channel.TargetHandle;org.freedesktop.Telepathy.Channel.TargetID;org.freedesktop.Telepathy.Channel.Type.Call1.InitialAudio;org.freedesktop.Telepathy.Channel.Type.Call1.InitialAudioName;org.freedesktop.T elepathy.Channel.Type.Call1.InitialVideo;org.freedesktop.Telepathy.Channel.Type.Call1.InitialVideoName;org.freedesktop.Telepathy.Channel.Type.Call1.MutableContents; ...which is not correct according to the spec, as the fixed properties do not contain Initial{Audio,Video}. This currently breaks tp-qt's capabilities detection, which follows the spec.