Summary: | Division by zero in poppler/PSOutputDev.cc:3132 | ||
---|---|---|---|
Product: | poppler | Reporter: | Octoploid <cryptooctoploid> |
Component: | utils | Assignee: | poppler-bugs <poppler-bugs> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | medium | ||
Version: | unspecified | ||
Hardware: | Other | ||
OS: | All | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=426674 | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: |
testcase
solves floating point exception |
Description
Octoploid
2012-07-17 21:55:51 UTC
I receive mails already, don't want them twice thanks In PSOutputDev::startPage, case mode == psModePSOrigPageSizes (line 3524), the initialization of xScale and yScale is missing, should be imo as in the other cases beside psModePS xScale = yScale = 1; (i.e. insert before line 3551) Without it, the calculation of hDPI2 and vDPI2(line 3117 ff) and therefore the calculation of stripes causes this floating point exception. Should I upload a new patch for bug 51982 which includes it, wait that it will be committed and create then a patch here or can You do that, Albert? Albert? Wait until i commit the one for 51982, regtesting almost done there, don't want to start again, takes ages :D Patch for 51982 pushed Created attachment 64480 [details] [review] solves floating point exception Here now my patch for it. The patch is slightly different to my suggested solution in comment 2 but does the same and is more secure for futur code changes. Pushed |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.